From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jeff Epler <jepler@unpythonic.net>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Mathias Krause <minipli@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] lib/string_helpers.c: Refactor string_escape_mem
Date: Fri, 30 Jan 2015 12:14:53 +0200 [thread overview]
Message-ID: <1422612893.31903.343.camel@linux.intel.com> (raw)
In-Reply-To: <20150129193319.GB21543@unpythonic.net>
On Thu, 2015-01-29 at 13:33 -0600, Jeff Epler wrote:
> [discussing the repeated three-line idiom]
> > if (out < end)
> > *out = '\\';
> > ++out;
>
> Instead of open-coding this each time, perhaps it would be appropriate
> to define a macro to possibly put a character and also advance the
> pointer.
>
> Assuming that the locals are consistently "out" and "end", something
> like
Why not inline function?
>
> #define addch(c) do { \
> if(out < end) *out = c; \
> ++out; \
> } while(0)
>
> modulo any errors or differences with standard kernel coding style.
What about vsprintf.c ?
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-01-30 10:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:25 [PATCH 0/2] Two printf fixes Rasmus Villemoes
2015-01-28 13:25 ` [PATCH 1/2] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes
2015-01-28 14:53 ` Andy Shevchenko
2015-01-28 15:49 ` Rasmus Villemoes
2015-01-28 16:43 ` Andy Shevchenko
2015-01-28 13:25 ` [PATCH 2/2] string_helpers: Change semantics of string_escape_mem Rasmus Villemoes
2015-01-28 15:05 ` Andy Shevchenko
2015-01-29 10:03 ` [PATCH v2 0/3] Two printf fixes Rasmus Villemoes
2015-01-29 10:03 ` [PATCH v2 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes
2015-01-29 10:43 ` Andy Shevchenko
2015-01-29 10:03 ` [PATCH v2 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes
2015-01-29 12:12 ` Andy Shevchenko
2015-01-29 13:10 ` Rasmus Villemoes
2015-01-29 13:37 ` Andy Shevchenko
2015-01-29 19:33 ` Jeff Epler
2015-01-30 10:14 ` Andy Shevchenko [this message]
2015-01-29 10:03 ` [PATCH v2 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes
2015-01-29 13:29 ` Andy Shevchenko
2015-01-29 14:29 ` Rasmus Villemoes
2015-01-30 10:27 ` Andy Shevchenko
2015-01-30 23:39 ` Rasmus Villemoes
2015-02-02 10:56 ` Andy Shevchenko
2015-02-09 23:44 ` [PATCH v3 0/3] Two printf fixes Rasmus Villemoes
2015-02-09 23:44 ` [PATCH v3 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes
2015-02-09 23:44 ` [PATCH v3 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes
2015-02-10 12:16 ` Andy Shevchenko
2015-02-09 23:44 ` [PATCH v3 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes
2015-02-10 12:32 ` Andy Shevchenko
2015-02-10 13:02 ` Rasmus Villemoes
2015-02-10 14:22 ` Andy Shevchenko
2015-02-21 1:35 ` Rasmus Villemoes
2015-02-23 12:50 ` Andy Shevchenko
2015-02-23 22:55 ` Rasmus Villemoes
2015-03-02 12:37 ` Andy Shevchenko
2015-03-02 23:03 ` Rasmus Villemoes
2015-03-03 10:26 ` Andy Shevchenko
2015-03-03 23:20 ` [PATCH v4 0/3] Two printf fixes Rasmus Villemoes
2015-03-03 23:20 ` [PATCH v4 1/3] lib/vsprintf.c: Fix potential NULL deref in hex_string Rasmus Villemoes
2015-03-03 23:20 ` [PATCH v4 2/3] lib/string_helpers.c: Refactor string_escape_mem Rasmus Villemoes
2015-03-04 10:51 ` Andy Shevchenko
2015-03-03 23:20 ` [PATCH v4 3/3] lib/string_helpers.c: Change semantics of string_escape_mem Rasmus Villemoes
2015-03-04 11:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422612893.31903.343.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jepler@unpythonic.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).