From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762985AbbA3Sf1 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 13:35:27 -0500
Received: from g4t3425.houston.hp.com ([15.201.208.53]:14125 "EHLO
	g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1763140AbbA3SfZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 13:35:25 -0500
Message-ID: <1422642921.3365.1.camel@j-VirtualBox>
Subject: Re: [RFC][PATCH] cpuset, sched: Fix cpuset sched_relax_domain_level
From: Jason Low <jason.low2@hp.com>
To: Zefan Li <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, aswin@hp.com,
        scott.norton@hp.com, chegu_vinod@hp.com, jason.low2@hp.com
Date: Fri, 30 Jan 2015 10:35:21 -0800
In-Reply-To: <54CB04DC.3090405@huawei.com>
References: <1422478025.4111.31.camel@j-VirtualBox>
	 <54CB04DC.3090405@huawei.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-01-30 at 12:13 +0800, Zefan Li wrote:
> On 2015/1/29 4:47, Jason Low wrote:
> > The cpuset.sched_relax_domain_level can control how far we do
> > immediate load balancing on a system. However, it was found on recent
> > kernels that echo'ing a value into cpuset.sched_relax_domain_level
> > did not reduce any immediate load balancing.
> > 
> > The reason this occurred was because the update_domain_attr_tree() traversal
> > did not update for the "top_cpuset". This resulted in nothing being changed
> > when modifying the sched_relax_domain_level parameter.
> > 
> > This patch was able to address that problem by having update_domain_attr_tree()
> > allowing updates for the root (top_cpuset) in the cpuset traversal.
> > 
> > Signed-off-by: Jason Low <jason.low2@hp.com>
> 
> Thanks for finding this bug!
> 
> Please Add:
> 
> Cc: <stable@vger.kernel.org> # 3.9+
> Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()")

Okay, I will send out a new version.

Thanks,
Jason