From: riel@redhat.com
To: oleg@redhat.com
Cc: dave.hansen@linux.intel.com, sbsiddha@gmail.com,
luto@amacapital.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, fenghua.yu@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] x86,fpu: also check fpu_lazy_restore when use_eager_fpu
Date: Mon, 2 Feb 2015 13:00:50 -0500 [thread overview]
Message-ID: <1422900051-10778-6-git-send-email-riel@redhat.com> (raw)
In-Reply-To: <1422900051-10778-1-git-send-email-riel@redhat.com>
From: Rik van Riel <riel@redhat.com>
With Oleg's patch "x86, fpu: don't abuse FPU in kernel threads if
use_eager_fpu()", kernel threads no longer have an FPU state even
on systems with use_eager_fpu()
That in turn means that a task may still have its FPU state
loaded in the FPU registers, if the task only got interrupted by
kernel threads from when it went to sleep, to when it woke up
again.
In that case, there is no need to restore the FPU state for
this task, since it is still in the registers.
The kernel can simply use the same logic to determine this as
is used for !use_eager_fpu() systems.
Signed-off-by: Rik van Riel <riel@redhat.com>
---
arch/x86/include/asm/fpu-internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/fpu-internal.h b/arch/x86/include/asm/fpu-internal.h
index e2832f9dfed5..085903415cbd 100644
--- a/arch/x86/include/asm/fpu-internal.h
+++ b/arch/x86/include/asm/fpu-internal.h
@@ -457,7 +457,7 @@ static inline fpu_switch_t switch_fpu_prepare(struct task_struct *old, struct ta
task_disable_lazy_fpu_restore(old);
if (fpu.preload) {
new->thread.fpu_counter++;
- if (!use_eager_fpu() && fpu_lazy_restore(new, cpu))
+ if (fpu_lazy_restore(new, cpu))
fpu.preload = 0;
else
prefetch(new->thread.fpu.state);
--
1.9.3
next prev parent reply other threads:[~2015-02-02 18:01 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 19:34 question about save_xstate_sig() - WHY DOES THIS WORK? Rik van Riel
2015-01-23 20:51 ` [PATCH, RFC] x86,fpu: make signal handling xstate save & restore preemption safe Rik van Riel
2015-01-23 21:07 ` question about save_xstate_sig() - WHY DOES THIS WORK? H. Peter Anvin
2015-01-24 13:39 ` Rik van Riel
2015-01-24 20:20 ` Oleg Nesterov
2015-01-26 23:27 ` Rik van Riel
2015-01-27 19:40 ` Oleg Nesterov
2015-01-27 20:27 ` Rik van Riel
2015-01-27 20:50 ` Rik van Riel
2015-01-29 21:01 ` Oleg Nesterov
2015-01-29 20:45 ` Oleg Nesterov
2015-01-29 20:52 ` Rik van Riel
2015-01-29 21:00 ` [PATCH RFC] x86,fpu: merge save_init_fpu & unlazy_fpu Rik van Riel
2015-01-29 21:21 ` Oleg Nesterov
2015-01-29 21:07 ` [PATCH 0/3]: x86, fpu: unlazy_fpu fixes/cleanups Oleg Nesterov
2015-01-29 21:07 ` [PATCH 1/3] x86, fpu: unlazy_fpu: don't reset thread.fpu_counter Oleg Nesterov
2015-01-29 21:26 ` Rik van Riel
2015-01-29 21:08 ` [PATCH 2/3] x86, fpu: unlazy_fpu: don't do __thread_fpu_end() if use_eager_fpu() Oleg Nesterov
2015-01-29 21:36 ` Rik van Riel
2015-01-29 21:49 ` Oleg Nesterov
2015-01-29 21:53 ` Rik van Riel
2015-01-29 21:54 ` Rik van Riel
2015-01-29 21:08 ` [PATCH 3/3] x86, fpu: kill save_init_fpu(), change math_error() to use unlazy_fpu() Oleg Nesterov
2015-01-29 21:54 ` Rik van Riel
2015-01-29 21:17 ` [PATCH 0/3]: x86, fpu: unlazy_fpu fixes/cleanups Dave Hansen
2015-01-29 21:33 ` Oleg Nesterov
2015-01-29 21:43 ` Dave Hansen
2015-01-29 21:56 ` Oleg Nesterov
2015-01-29 21:58 ` Rik van Riel
2015-01-29 23:26 ` Dave Hansen
2015-01-30 1:33 ` Rik van Riel
2015-02-02 18:11 ` Dave Hansen
2015-01-30 12:45 ` Oleg Nesterov
2015-01-30 13:30 ` Oleg Nesterov
2015-01-30 13:43 ` Oleg Nesterov
2015-01-30 17:49 ` [PATCH 0/3] cleanups to the disable lazy fpu restore code riel
2015-01-30 17:49 ` [PATCH 1/3] x86,fpu: move lazy restore functions up a few lines riel
2015-01-30 17:49 ` [PATCH 2/3] x86,fpu: introduce task_disable_lazy_fpu_restore helper riel
2015-01-30 17:49 ` [PATCH 3/3] x86,fpu: use disable_task_lazy_fpu_restore helper riel
2015-01-30 21:46 ` Dave Hansen
2015-01-30 21:48 ` Rik van Riel
2015-02-02 17:56 ` Rik van Riel
2015-02-02 18:00 ` [PATCH 0/6] cleanups to lazy FPU restore code riel
2015-02-02 18:00 ` [PATCH 1/6] x86,fpu: move lazy restore functions up a few lines riel
2015-02-02 18:00 ` [PATCH 2/6] x86,fpu: introduce task_disable_lazy_fpu_restore helper riel
2015-02-02 18:00 ` [PATCH 3/6] x86,fpu: use an explicit if/else in switch_fpu_prepare riel
2015-02-02 18:00 ` [PATCH 4/6] x86,fpu: use disable_task_lazy_fpu_restore helper riel
2015-02-02 19:21 ` Oleg Nesterov
2015-02-02 19:43 ` Rik van Riel
2015-02-03 19:08 ` Oleg Nesterov
2015-02-03 22:01 ` Rik van Riel
2015-02-06 16:42 ` Rik van Riel
2015-02-02 18:00 ` riel [this message]
2015-02-02 18:55 ` [PATCH 5/6] x86,fpu: also check fpu_lazy_restore when use_eager_fpu Oleg Nesterov
2015-02-02 19:19 ` Rik van Riel
2015-02-02 18:00 ` [PATCH 6/6] x86,fpu: remove redundant increments of fpu_counter riel
2015-02-02 18:34 ` Oleg Nesterov
2015-02-02 18:40 ` Rik van Riel
2015-02-18 23:40 ` Ingo Molnar
2015-02-18 23:54 ` Borislav Petkov
2015-02-19 20:09 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422900051-10778-6-git-send-email-riel@redhat.com \
--to=riel@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=sbsiddha@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).