From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701AbbBBScK (ORCPT ); Mon, 2 Feb 2015 13:32:10 -0500 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:38844 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754414AbbBBScH (ORCPT ); Mon, 2 Feb 2015 13:32:07 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3866:3867:3868:3871:4321:4384:5007:6119:6261:8957:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12517:12519:12740:13019:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tray26_868393141572d X-Filterd-Recvd-Size: 1973 Message-ID: <1422901922.30476.8.camel@perches.com> Subject: Re: [PATCH 2/2] staging/unisys/visorutil/procobjecttree: Replace typedef From: Joe Perches To: Ricardo Ribalda Delgado Cc: Masaru Nomura , Peter P Waskiewicz Jr , Tapasweni Pathak , Iulia Manda , Catalina Mocanu , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 02 Feb 2015 10:32:02 -0800 In-Reply-To: <1422901593-5707-3-git-send-email-ricardo.ribalda@gmail.com> References: <1422901593-5707-1-git-send-email-ricardo.ribalda@gmail.com> <1422901593-5707-3-git-send-email-ricardo.ribalda@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-02 at 19:26 +0100, Ricardo Ribalda Delgado wrote: > Instead of declaring a new type, define a new struct. [] > diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers/staging/unisys/visorutil/procobjecttree.c [] > @@ -340,7 +341,9 @@ EXPORT_SYMBOL_GPL(visor_proc_DestroyObject); > > static int seq_show(struct seq_file *seq, void *offset) > { > - PROCDIRENTRYCONTEXT *ctx = (PROCDIRENTRYCONTEXT *)(seq->private); > + struct proc_dir_entry_context *ctx; > + > + ctx = (struct proc_dir_entry_context *)(seq->private); seq-private is a void * and doesn't need to be cast here. struct proc_dir_entry_context *ctx = seq->private; should work well enough. > > if (ctx == NULL) { > ERRDRV("I don't have a freakin' clue...");