public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Anshul Garg <aksgarg1989@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	anshul.g@samsung.com
Subject: Re: [PATCH] lib/int_sqrt.c: Optimize square root function
Date: Mon, 02 Feb 2015 20:57:17 -0800	[thread overview]
Message-ID: <1422939437.2293.6.camel@stgolabs.net> (raw)
In-Reply-To: <1422938501.2293.1.camel@stgolabs.net>

On Mon, 2015-02-02 at 20:41 -0800, Davidlohr Bueso wrote:
> On Mon, 2015-02-02 at 11:13 -0800, Linus Torvalds wrote:
> > IOW, instead of
> > 
> >   m = 1UL << (BITS_PER_LONG - 2);
> > 
> > perhaps something like
> > 
> >    m = 1UL << (BITS_PER_LONG/2- 2);
> >    if (m < x)
> >        m <<= BITS_PER_LONG/2;

Assuming small values mostly, we could also try more aggressive
estimators for BITS_PER_LONG == 64. But then again, it probably doesn't
matter.


  reply	other threads:[~2015-02-03  4:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 17:12 [PATCH] lib/int_sqrt.c: Optimize square root function Anshul Garg
2015-02-02 19:00 ` Linus Torvalds
2015-02-02 19:13   ` Linus Torvalds
2015-02-03  4:41     ` Davidlohr Bueso
2015-02-03  4:57       ` Davidlohr Bueso [this message]
2015-02-03 15:54       ` Anshul Garg
2017-07-20 11:24     ` Peter Zijlstra
2017-07-20 11:52       ` Joe Perches
2017-07-20 14:13         ` Peter Zijlstra
2017-07-20 15:27       ` Peter Zijlstra
2017-07-20 18:31       ` Linus Torvalds
2017-07-20 22:34         ` Peter Zijlstra
2017-07-20 23:24           ` Linus Torvalds
2017-07-21 11:40             ` Peter Zijlstra
2017-07-21 12:15               ` Joe Perches
2017-07-21 13:26                 ` Peter Zijlstra
2017-07-21 13:33                   ` Peter Zijlstra
2015-02-03  4:47   ` Davidlohr Bueso
2015-02-03 15:42     ` Anshul Garg
2015-02-05 18:20       ` Linus Torvalds
2015-02-05 18:33         ` Linus Torvalds
2015-02-05 18:43           ` Anshul Garg
2015-02-05 19:37             ` Linus Torvalds
2015-02-08 15:39               ` Anshul Garg
2015-02-02 19:10 ` Joe Perches
2015-02-02 19:39   ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2015-01-29 13:35 Anshul Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422939437.2293.6.camel@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=aksgarg1989@gmail.com \
    --cc=anshul.g@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox