From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbbBDGrc (ORCPT ); Wed, 4 Feb 2015 01:47:32 -0500 Received: from smtprelay0232.hostedemail.com ([216.40.44.232]:60924 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751542AbbBDGra (ORCPT ); Wed, 4 Feb 2015 01:47:30 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3865:3867:3868:3870:3872:3874:4321:4362:4605:5007:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12050:12296:12517:12519:12663:12740:13069:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: snake74_412043e3d335f X-Filterd-Recvd-Size: 2225 Message-ID: <1423032445.16386.1.camel@perches.com> Subject: Re: linux-next: build failure after merge of the scsi tree From: Joe Perches To: Stephen Rothwell Cc: James Bottomley , Greg KH , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Christoph Hellwig Date: Tue, 03 Feb 2015 22:47:25 -0800 In-Reply-To: <20150204172925.728016bf@canb.auug.org.au> References: <20150204172925.728016bf@canb.auug.org.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding Christoph Hellwig) On Wed, 2015-02-04 at 17:29 +1100, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/scsi/scsi_logging.c: In function 'sdev_prefix_printk': > drivers/scsi/scsi_logging.c:119:6: error: void value not ignored as it ought to be > ret = dev_printk(level, &sdev->sdev_gendev, "%s", logbuf); > ^ > drivers/scsi/scsi_logging.c: In function 'scmd_printk': > drivers/scsi/scsi_logging.c:146:6: error: void value not ignored as it ought to be > ret = dev_printk(level, &scmd->device->sdev_gendev, "%s", logbuf); > ^ > > Caused by commit ded85c193a39 ("scsi: Implement per-cpu logging > buffer") interacting with commit d1f1052c5204 ("device: Change > dev_ logging functions to return void") from the driver-core > tree. > > I added the following merge resolution patch. Someone will have to > remember to tell Linus. Also, the void return may be able to be > propagated further up the chain since these two new affected functions > now always return 0. Thanks and just so. It seems that nothing uses either return value, so it's probably better to use void for both sdev_prefix_printk and scmd_printk.