From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966007AbbBDKuV (ORCPT ); Wed, 4 Feb 2015 05:50:21 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:16235 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965620AbbBDKuP (ORCPT ); Wed, 4 Feb 2015 05:50:15 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-a5-54d1f8d4a34a Content-transfer-encoding: 8BIT Message-id: <1423047011.3987.2.camel@AMDC1943> Subject: Re: [PATCH] regulator: Fix build breakage on !REGULATOR From: Krzysztof Kozlowski To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz , Joerg Roedel Date: Wed, 04 Feb 2015 11:50:11 +0100 In-reply-to: <1423046728-31000-1-git-send-email-k.kozlowski@samsung.com> References: <1423046728-31000-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGLMWRmVeSWpSXmKPExsVy+t/xK7pXflwMMTg9lc1i44z1rBZTHz5h s+icvYHd4tuVDiaLy7vmsFmsPXKX3YHN48nBeUweO2fdZffYtKqTzaNvyypGj8+b5AJYo7hs UlJzMstSi/TtErgylk6ayF7wmq/i24VLbA2M53i6GDk4JARMJDa32HYxcgKZYhIX7q1n62Lk 4hASWMoocbT3PDNIgldAUOLH5HssIPXMAvISRy5lg4SZBdQlJs1bxAxR/5lR4vurcywQ9XoS e+a9ZwWxhQUcJPoOXwCbwyZgLLF5+RI2EFtEwEOidfsGsGZmgeWMEkde9zKBJFgEVCXOXLsN ZnOCFH36BtYgJOAu8WPCbxaIo5UlGvvdJjAKzEJy3iyE82YhOW8BI/MqRtHU0uSC4qT0XEO9 4sTc4tK8dL3k/NxNjJCw/rKDcfExq0OMAhyMSjy8DW0XQ4RYE8uKK3MPMUpwMCuJ8FYfAwrx piRWVqUW5ccXleakFh9iZOLglGpglOTT3Pv/3pua36WZWyZte/2rUEOkS26b5Ild3pOftgrf P2nH8HLV/NmRuWHekQt/sVZtFX0RaxgxUXBrd1lPVVtbkt3mFI9Klcyd8fGcew3DQj/sFj33 17Jkue+Fq4ob852UZ7kwz1etbn7lY5im+J+54dfn6sOBW5Zz7Zt06hS79kWnU4qpSizFGYmG WsxFxYkAw2AEMEkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On śro, 2015-02-04 at 11:45 +0100, Krzysztof Kozlowski wrote: > Add missing stubs for regulator_suspend_prepare() and > regulator_suspend_finish() to fix exynos_defconfig build without > REGULATOR: > > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_finish': > arch/arm/mach-exynos/suspend.c:537: undefined reference to `regulator_suspend_finish' > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_prepare': > arch/arm/mach-exynos/suspend.c:520: undefined reference to `regulator_suspend_prepare' > make: *** [vmlinux] Error 1 > > Signed-off-by: Krzysztof Kozlowski > Reported-by: Joerg Roedel > Reported-by: Marek Szyprowski Heh, git send-email does not CC to reported-by people so +CC Joerg Roedel for credits for: https://lkml.org/lkml/2015/1/26/790 > --- > include/linux/regulator/machine.h | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/include/linux/regulator/machine.h b/include/linux/regulator/machine.h > index 0b08d05d470b..b07562e082c4 100644 > --- a/include/linux/regulator/machine.h > +++ b/include/linux/regulator/machine.h > @@ -191,15 +191,22 @@ struct regulator_init_data { > void *driver_data; /* core does not touch this */ > }; > > -int regulator_suspend_prepare(suspend_state_t state); > -int regulator_suspend_finish(void); > - > #ifdef CONFIG_REGULATOR > void regulator_has_full_constraints(void); > +int regulator_suspend_prepare(suspend_state_t state); > +int regulator_suspend_finish(void); > #else > static inline void regulator_has_full_constraints(void) > { > } > +static inline int regulator_suspend_prepare(suspend_state_t state) > +{ > + return 0; > +} > +static inline int regulator_suspend_finish(void) > +{ > + return 0; > +} > #endif > > #endif