From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling
Date: Thu, 05 Feb 2015 14:23:11 +0200 [thread overview]
Message-ID: <1423138991.6471.9.camel@mm-sol.com> (raw)
In-Reply-To: <54D24FDE.7000908@kernel.org>
On Wed, 2015-02-04 at 16:59 +0000, Jonathan Cameron wrote:
> On 02/02/15 08:37, Nicholas Mc Guire wrote:
> > This patch fixes two issues:
> > * return type of wait_for_completion_timeout is unsigned long not int,
> > rather than adding a dedicated variable the wait_for_completion_timeout
> > is moved into the condition directly
> > * the timeout of wait_for_completion_timeout is in jiffies but the value
> > being passed was a unsigned long not converted to jiffies and thus was
> > dependent on the HZ settings which is probably not what you want.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Ivan, need your Ack / Reviewed-by on this one.
>
Yes, change is correct, as explained before [1].
Acked-by: Ivan T. Ivanov <iivanov@mm-sol.com>
[1] https://lkml.org/lkml/2015/1/5/409
prev parent reply other threads:[~2015-02-05 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 8:37 [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling Nicholas Mc Guire
2015-02-04 16:59 ` Jonathan Cameron
2015-02-05 12:23 ` Ivan T. Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423138991.6471.9.camel@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=hofrat@osadl.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox