From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andreas Ruprecht <rupran@einserver.de>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, "Lad,
Prabhakar" <prabhakar.csengg@gmail.com>
Subject: Re: use of opaque subject lines
Date: Thu, 05 Feb 2015 09:08:59 -0800 [thread overview]
Message-ID: <1423156139.4752.1.camel@perches.com> (raw)
In-Reply-To: <20150205163053.GQ29656@ZenIV.linux.org.uk>
On Thu, 2015-02-05 at 16:30 +0000, Al Viro wrote:
> On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote:
>
> > On a serious note: I do understand what you're getting at, I don't take
> > that personally (and I will send a v2 addressing the things above), but
> > honestly, this kind of answer might just be a real turn-off for other
> > people trying to get into kernel development...
> >
> > I don't want to start a whole new 'attitude in the kernel community'
> > discussion, but I can't just let this go like that, sorry.
Maybe YA checkpatch warning when patch subjects
include either "checkpatch" or "sparse" would help?
Something like:
---
scripts/checkpatch.pl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3642b0d..b6bed59 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2170,6 +2170,13 @@ sub process {
}
}
+# Check email subject for poor style
+ if ($in_header_lines &&
+ $line =~ /^Subject:.*\b(?:checkpatch|sparse)\b[^:]/i) {
+ WARN("EMAIL_SUBJECT",
+ "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
+ }
+
# Check for old stable address
if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) {
ERROR("STABLE_ADDRESS",
next prev parent reply other threads:[~2015-02-05 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 13:36 [PATCH] staging: lustre: osc: Fix sparse warning about osc_init Andreas Ruprecht
2015-02-02 14:16 ` Al Viro
2015-02-02 19:13 ` Andreas Ruprecht
2015-02-05 16:30 ` use of opaque subject lines Al Viro
2015-02-05 16:57 ` Lad, Prabhakar
2015-02-05 17:57 ` Greg Kroah-Hartman
2015-02-05 18:22 ` Lad, Prabhakar
2015-02-05 19:32 ` Paul Bolle
2015-02-05 20:06 ` Greg Kroah-Hartman
2015-02-05 20:53 ` Joe Perches
2015-02-05 17:08 ` Joe Perches [this message]
2015-02-05 17:25 ` Dan Carpenter
2015-02-05 17:31 ` Joe Perches
2015-02-05 17:32 ` Joe Perches
2015-02-05 17:35 ` Dan Carpenter
2015-02-05 18:01 ` Joe Perches
2015-02-05 18:26 ` Dan Carpenter
2015-02-05 18:03 ` Greg Kroah-Hartman
2015-02-02 19:24 ` [PATCH] staging: lustre: osc: Make osc_init() static Andreas Ruprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423156139.4752.1.camel@perches.com \
--to=joe@perches.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=prabhakar.csengg@gmail.com \
--cc=rupran@einserver.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox