public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] checkpatch: Try to avoid poor patch subject lines
@ 2015-02-05 18:14 Joe Perches
  0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2015-02-05 18:14 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Andy Whitcroft, Al Viro, Dan Carpenter, Greg Kroah-Hartman, LKML

Naming the tool that found an issue in the subject line isn't
very useful.   Emit a warning when a common tool (currently
checkpatch, sparse or smatch) is in the subject line.

Signed-off-by: Joe Perches <joe@perches.com>
Inspired-by: Al Viro <viro@ZenIV.linux.org.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 scripts/checkpatch.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3642b0d..b6bed59 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2170,6 +2170,13 @@ sub process {
 			}
 		}
 
+# Check email subject for common tools that don't need to be mentioned
+		if ($in_header_lines &&
+		    $line =~ /^Subject:.*\b(?:checkpatch|sparse|smatch)\b[^:]/i) {
+			WARN("EMAIL_SUBJECT",
+			     "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
+		}
+
 # Check for old stable address
 		if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) {
 			ERROR("STABLE_ADDRESS",




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-02-05 18:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-05 18:14 [PATCH] checkpatch: Try to avoid poor patch subject lines Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox