From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755520AbbBFOnZ (ORCPT ); Fri, 6 Feb 2015 09:43:25 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:54823 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbbBFOnV (ORCPT ); Fri, 6 Feb 2015 09:43:21 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f5-b7fc86d0000066b7-5a-54d4d2738068 Content-transfer-encoding: 8BIT Message-id: <1423233788.31516.5.camel@AMDC1943> Subject: Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter From: Krzysztof Kozlowski To: Pavel Machek Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Jiri Kosina , David Herrmann , Cezary Jackiewicz , Darren Hart , Support Opensource , Milo Kim , Julian Andres Klode , Marc Dietrich , Greg Kroah-Hartman , linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Linus Walleij , Samuel Ortiz , Lee Jones , linux-arm-kernel@lists.infradead.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Thomas Gleixner , Kyungmin Park , Bartlomiej Zolnierkiewicz Date: Fri, 06 Feb 2015 15:43:08 +0100 In-reply-to: <20150206134953.GA25683@amd> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+XsuO1tNjpfsj4SFXUQhNYt6qQixiEPRDYSoD+VxDrWcyo5K CpWX+uBcamlSQ1c259TM6aSynBpLTZu3VETxUplahF1MLbHU3ITy24+X53n4fXgZwjmFcmci o+Pkymg+ypOWkNbFV33bhe7eYP/6KQ/IbP/uAFV3jBQUtWSQkLrwmYRbY98IMLfNi0DX4waq Qn+4WZpDQJrOSENXxR7Iq1oPxVP3aKjN15HQnjopgrezTQievf9CQ+4fgwMY6rMQmD70UTDw 4ycFPc/zaZi+0YggfUZDw2CPFNI7CxEY5itI6H5xf7nwZYmG4ddNNDw0fyKgzdpNgWbSBawZ FFhr46Du+hsCqk23CZir/EAFbuOupalpruSHHzdS/5LksiqmKe6ZZljEfZ86x41n54i46hIf buyzgeJMZek0N9RnprmvHR0iTtt6imsoKF8OFF3lmtRD5En3s5L9YfKoyAS50u9AiCTio2qE ii2WXMprbqGTURmjQmIGs7twQeVveoXdcNeI0c7OrB7hcXOEjaWsE57LGSFViGEIdiNu7L5o OxOsF76lfUCokGQ5Po3wr6lGaiXvhzN0ucjGLmwYfvfeKLIxze7E1YYi+77r8s7jzBJ7mWDn JXhBX2ovkOxWnFzRaQ+JWW88oX+K/gmNVrI2CcxuxilZh7MRq1mlp/mvp1mldx8RZWidPF4W K4SGKwJ8BV4hxEeH+8piFCa08jazNUjfvNeCWAZ5rpX2H+kJdqb4BCFRYUGYITxdpWp9b7Cz NIxPTJIrY84r46PkggU5MGL3ZLSBD/SSqwtOlHiVegw0vxp02rf2aLlJrX0bctwiC2hoD98k Dnvup3dUFRtQ7kvZlpmEGqsobzgltUubOjjqvab30F02svlwv/SKh2JRVGC+4NgammQO6lqU HtRfX0o4LT0jpN9beOTacHkyqFLneKxP90TGi5cmYue07gu7O+o8SSGC3+FDKAX+LwBtfcgU AwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > Use power_supply_put() to decrement the power supply's device reference > > counter. > > > > Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Bartlomiej Zolnierkiewicz > > Reviewed-by: Sebastian Reichel > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > closely enough to warrant an ACK. > > It would be good to get this into kernel -- I seen no bad comments, > and it is not going to improve without merge into mainline. Thanks for looking at patchset. It would be really nice if this could be tested for some time in linux-next. Such testing would help a lot. But I need acks from various maintainers for that. Of course the patchset to big enough to go into 3.20. If needed this could be taken gradually in following steps: 1. Patches 1-2 (patch 2 touches *all drivers*), 2. Patches 3-10 (touch only individual drivers), 3. Patch 11 (again *everything* changed), 4. Patches 12-20 (individual changes). In such case I will refresh everything after each step so new drivers would be also updated. Thanks again Pavel for prompt replies. Best regards, Krzysztof