From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756617AbbBFVEg (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Feb 2015 16:04:36 -0500
Received: from smtprelay0220.hostedemail.com ([216.40.44.220]:56435 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1755386AbbBFVEf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Feb 2015 16:04:35 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3868:3871:3872:4250:4321:5007:6261:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13095:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: form29_61d37d89c8e40
X-Filterd-Recvd-Size: 1491
Message-ID: <1423256670.4752.16.camel@perches.com>
Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message
From: Joe Perches <joe@perches.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Quentin Lambert <lambert.quentin@gmail.com>,
        Ming Lei <ming.lei@canonical.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Date: Fri, 06 Feb 2015 13:04:30 -0800
In-Reply-To: <20150206205852.GA14126@amd>
References: <20150206153912.GA8486@sloth> <20150206205852.GA14126@amd>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote:
> On Fri 2015-02-06 16:39:12, Quentin Lambert wrote:
> > This patch fix checkpatch warnings concerning the possible
> > duplication of an "out of memory" message.
> 
> So, instead of nice and readable "not enough memory for clock..." we
> get OOM, stackdump, and backtrace...? Not sure it is improvement.

All allocs without __GFP_NOWARN already gets an OOM and stackdump.
These are just unnecessary.