From: Joe Perches <joe@perches.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
Pravin B Shelar <pshelar@nicira.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vxlan: Wrong type passed to %pIS
Date: Fri, 06 Feb 2015 19:35:38 -0800 [thread overview]
Message-ID: <1423280138.2933.3.camel@perches.com> (raw)
In-Reply-To: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk>
On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote:
> src_ip is a pointer to a union vxlan_addr, one member of which is a
> struct sockaddr. Passing a pointer to src_ip is wrong; one should pass
> the value of src_ip itself. Since %pIS formally expects something of
> type struct sockaddr*, let's pass a pointer to the appropriate union
> member, though this of course doesn't change the generated code.
Hello Rasmus
Are you finding these mismatches by hand or
are you using some tool?
next prev parent reply other threads:[~2015-02-07 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 2:17 [PATCH] vxlan: Wrong type passed to %pIS Rasmus Villemoes
2015-02-07 3:35 ` Joe Perches [this message]
2015-02-07 12:38 ` Rasmus Villemoes
2015-02-07 5:13 ` Cong Wang
2015-02-07 12:34 ` Rasmus Villemoes
2015-02-07 23:31 ` Cong Wang
2015-02-09 1:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423280138.2933.3.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox