From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755912AbbBHJzE (ORCPT ); Sun, 8 Feb 2015 04:55:04 -0500 Received: from smtprelay0169.hostedemail.com ([216.40.44.169]:34838 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753429AbbBHJzC (ORCPT ); Sun, 8 Feb 2015 04:55:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3871:3872:3876:4321:4384:5007:6261:9040:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: brake10_2b83ca95ba054 X-Filterd-Recvd-Size: 1635 Message-ID: <1423389297.2933.13.camel@perches.com> Subject: Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements From: Joe Perches To: Tolga Ceylan Cc: Greg Kroah-Hartman , Sanjeev Sharma , Mohammad Jamal , =?ISO-8859-1?Q?Lo=EFc?= Pellegrino , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 08 Feb 2015 01:54:57 -0800 In-Reply-To: <1423388966-8204-1-git-send-email-tolga.ceylan@gmail.com> References: <1423388966-8204-1-git-send-email-tolga.ceylan@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote: > Lines over 80 were corrected [] > diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c [] > @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, HT_CHANNEL_WIDTH Bandwidth) [] > + /* 8256 D-cut, E-cut, xiong: consider it later! */ > + if (priv->card_8192_version == VERSION_819xU_A > + || priv->card_8192_version == VERSION_819xU_B) { This is more commonly written: if (priv->card_8192_version == VERSION_819xU_A || priv->card_8192_version == VERSION_819xU_B) {