From: Steven Whitehouse <swhiteho@redhat.com>
To: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Cc: Bob Peterson <rpeterso@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: [PATCH 3/5] GFS2: Eliminate a nonsense goto
Date: Tue, 10 Feb 2015 10:36:22 +0000 [thread overview]
Message-ID: <1423564584-12488-4-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1423564584-12488-1-git-send-email-swhiteho@redhat.com>
From: Bob Peterson <rpeterso@redhat.com>
This patch just removes a goto that did nothing.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9054002..73c72253 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
}
error = gfs2_dir_add(&dip->i_inode, name, ip, da);
- if (error)
- goto fail_end_trans;
-fail_end_trans:
gfs2_trans_end(sdp);
fail_ipreserv:
gfs2_inplace_release(dip);
--
1.8.3.1
next prev parent reply other threads:[~2015-02-10 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 10:36 GFS2: Pre-pull patch posting Steven Whitehouse
2015-02-10 10:36 ` [PATCH 1/5] GFS2: Eliminate __gfs2_glock_remove_from_lru Steven Whitehouse
2015-02-10 10:36 ` [PATCH 2/5] GFS2: fix sprintf format specifier Steven Whitehouse
2015-02-10 10:36 ` Steven Whitehouse [this message]
2015-02-10 10:36 ` [PATCH 4/5] GFS2: use __vmalloc GFP_NOFS for fs-related allocations Steven Whitehouse
2015-02-10 10:36 ` [PATCH 5/5] GFS2: Fix crash during ACL deletion in acl max entry check in gfs2_set_acl() Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423564584-12488-4-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).