From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbbBKH3m (ORCPT ); Wed, 11 Feb 2015 02:29:42 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:63445 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbbBKH3k (ORCPT ); Wed, 11 Feb 2015 02:29:40 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-a6-54db044e3951 Message-id: <1423639776.19979.2.camel@AMDC1943> Subject: Re: [PATCH v2] ARM: dts: exynos5420: Add maudio power domain From: Krzysztof Kozlowski To: Kukjin Kim Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas Date: Wed, 11 Feb 2015 08:29:36 +0100 In-reply-to: <1423490243-7675-1-git-send-email-k.kozlowski@samsung.com> References: <1423490243-7675-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t/xa7p+LLdDDCZukrbYOGM9q8X8I+dY LY7+LrDof/ya2WLT42usFpd3zWGzmHF+H5PF2iN32R04PP4+v87isWlVJ5vH5iX1Hn1bVjF6 fN4kF8AaxWWTkpqTWZZapG+XwJUxr3M7e8EigYoZjavZGxhf83QxcnBICJhITOgJ7mLkBDLF JC7cW88GYgsJLGWUWPxftYuRC8j+zCixZuUydpAEr4C+xMF1a1hBbGEBV4mWrysZQWw2AWOJ zcuXsIHMFBFQlNi8QAGkl1lgDZPEju2TmUFqWARUJSbPuA/WyyngLtF0ei8LxDI3iS0TvjKB 2MwC6hKT5i1ihrhNWaKx3w1iraDEj8n3WCBK5CU2r3nLPIFRYBaSjllIymYhKVvAyLyKUTS1 NLmgOCk910ivODG3uDQvXS85P3cTIyTMv+5gXHrM6hCjAAejEg+vRcytECHWxLLiytxDjBIc zEoivNlvgEK8KYmVValF+fFFpTmpxYcYmTg4pRoYG4/tjyrTOCTTIVK1auP5n5/fpd4ruTvl RMneSYt/pdS+LZxxPoilRfD05/60le8VQu7J7/N8lVWxZWPP+u+7npgLfOWy4Lk5Qf1Ru55z yp+pclxWP59yMDbNZXuVc6C56Kz1V1f5eUfP/xR0eydT1v+rcZeRjNHMBSKHshvV14Zo7Qta 1LTkghJLcUaioRZzUXEiADCVOptRAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2015-02-09 at 14:57 +0100, Krzysztof Kozlowski wrote: > Add maudio power domain to Exynos 5420 DTSI file so its state could be > tracked. This actually won't power down this domain because the pl330 > dmaengine driver (for adma channel) uses IRQ safe runtime PM. Thus the > patch should not introduce any functional change except of visibility of > this domain to the system. I was wrong. There is a functional change during suspend. The mau domain is powered off after suspending adma device (pl330 dma). However later clk-exynos-audss receives syscore suspend notification and tries to save mau clock registers. This results in imprecise abort because mau power domain is turned off. I think it is better to drop my patch. Krzysztof > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas > > --- > > Changes sinve v1: > 1. Use generic power domain bindings (suggested by Javier). > 2. Add Javier's reviewed-by. > --- > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 9dc2e9773b30..28c4a2f4b991 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -288,6 +288,12 @@ > "pclk1", "clk1", "pclk2", "clk2"; > }; > > + mau_pd: power-domain@100440E0 { > + compatible = "samsung,exynos4210-pd"; > + reg = <0x100440E0 0x20>; > + #power-domain-cells = <0>; > + }; > + > pinctrl_0: pinctrl@13400000 { > compatible = "samsung,exynos5420-pinctrl"; > reg = <0x13400000 0x1000>; > @@ -346,6 +352,7 @@ > #dma-cells = <1>; > #dma-channels = <6>; > #dma-requests = <16>; > + power-domains = <&mau_pd>; > }; > > pdma0: pdma@121A0000 { > @@ -415,6 +422,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&i2s0_bus>; > status = "disabled"; > + power-domains = <&mau_pd>; > }; > > i2s1: i2s@12D60000 {