From: Ian Kent <raven@themaw.net>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] autofs4: Wrong format for printing dentry
Date: Thu, 12 Feb 2015 09:08:51 +0800 [thread overview]
Message-ID: <1423703331.2663.2.camel@pluto.fritz.box> (raw)
In-Reply-To: <87bnl0w58e.fsf@rasmusvillemoes.dk>
On Wed, 2015-02-11 at 21:41 +0100, Rasmus Villemoes wrote:
> Ping...
The patch looks fine to me.
I'll check there are no other instances of this and send it to Al.
>
> On Fri, Feb 06 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
> > %pD for struct file*, %pd for struct dentry*.
> >
> > Fixes: a455589f181e ("assorted conversions to %p[dD]")
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > ---
> > fs/autofs4/root.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
> > index dbb5b7212ce1..7ba355b8d4ac 100644
> > --- a/fs/autofs4/root.c
> > +++ b/fs/autofs4/root.c
> > @@ -108,7 +108,7 @@ static int autofs4_dir_open(struct inode *inode, struct file *file)
> > struct dentry *dentry = file->f_path.dentry;
> > struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
> >
> > - DPRINTK("file=%p dentry=%p %pD", file, dentry, dentry);
> > + DPRINTK("file=%p dentry=%p %pd", file, dentry, dentry);
> >
> > if (autofs4_oz_mode(sbi))
> > goto out;
prev parent reply other threads:[~2015-02-12 1:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 15:28 [PATCH] autofs4: Wrong format for printing dentry Rasmus Villemoes
2015-02-11 20:41 ` Rasmus Villemoes
2015-02-12 1:08 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423703331.2663.2.camel@pluto.fritz.box \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox