From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbbBMKFb (ORCPT ); Fri, 13 Feb 2015 05:05:31 -0500 Received: from smtprelay0249.hostedemail.com ([216.40.44.249]:52765 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751806AbbBMKFa (ORCPT ); Fri, 13 Feb 2015 05:05:30 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6121:6261:6757:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12663:12740:13069:13311:13357:13869:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: sock20_871f007cb4558 X-Filterd-Recvd-Size: 2759 Message-ID: <1423821927.2795.3.camel@perches.com> Subject: Re: [PATCH 6/9] nbd: Restructure debugging prints From: Joe Perches To: Markus Pargmann Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Fri, 13 Feb 2015 02:05:27 -0800 In-Reply-To: <20150213095850.GA10654@pengutronix.de> References: <1423774657-12748-1-git-send-email-mpa@pengutronix.de> <1423774657-12748-7-git-send-email-mpa@pengutronix.de> <1423775328.15343.38.camel@perches.com> <20150213095850.GA10654@pengutronix.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-02-13 at 10:58 +0100, Markus Pargmann wrote: > On Thu, Feb 12, 2015 at 01:08:48PM -0800, Joe Perches wrote: > > On Thu, 2015-02-12 at 21:57 +0100, Markus Pargmann wrote: > > > dprintk has some name collisions with other frameworks and drivers. It > > > is also not necessary to have these custom debug print filters. Dynamic > > > debug offers the same amount of filtered debugging. > > > > > > This patch replaces all dprintks with dev_dbg(). It also removes the > > > ioctl dprintk which prints the ingoing ioctls which should be > > > replaceable by strace or similar stuff. > > > > Perhaps add > > > > #define nbd_dbg(nbd, fmt, ...) \ > > dev_dbg(disk_to_dev((nbd)->disk), "%s: " fmt, \ > > nbd->disk->disk_name, ##__VA_ARGS__) > > I am not really happy with those custom debug print macros. What do you > think about an inline function 'nbd_to_dev' instead? Wouldn't that change the output? What would the output look like? > > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > > [] > > > +static void nbd_end_request(struct nbd_device *nbd, struct request *req) > > > { > > > int error = req->errors ? -EIO : 0; > > > struct request_queue *q = req->q; > > > unsigned long flags; > > > > > > - dprintk(DBG_BLKDEV, "%s: request %p: %s\n", req->rq_disk->disk_name, > > > - req, error ? "failed" : "done"); > > > + dev_dbg(disk_to_dev(nbd->disk), "%s: request %p: %s\n", > > > + req->rq_disk->disk_name, req, error ? "failed" : "done"); > > > > so this becomes > > > > nbd_dbg(nbd, "request %p: %s\n", > > req, error ? "failed" : "done"); > > so this would be: > nbd_dbg(nbd_to_dev(nbd), "request %p: %s\n", > req, error ? "failed" : "done"); I don't see much value in that style, but I don't manage the code either.