From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, <lejun.zhu@linux.intel.com>,
<bin.yang@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from devm_gpiod_get_index()
Date: Fri, 13 Feb 2015 15:01:14 +0200 [thread overview]
Message-ID: <1423832475-5803-2-git-send-email-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com>
It is usually better to pass actual error code from a function call than
mangling it to another.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
I haven't seen any issue with this. Random observation by looking at the code.
---
drivers/mfd/intel_soc_pmic_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
index 08c8e3dafaf5..40488e5b52ef 100644
--- a/drivers/mfd/intel_soc_pmic_core.c
+++ b/drivers/mfd/intel_soc_pmic_core.c
@@ -33,7 +33,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev)
desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0);
if (IS_ERR(desc))
- return -ENOENT;
+ return PTR_ERR(desc);
irq = gpiod_to_irq(desc);
if (irq < 0)
--
2.1.4
next prev parent reply other threads:[~2015-02-13 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:01 [PATCH 1/3] mfd: intel_soc_pmic: Move PMIC interrupt comment to probe function Jarkko Nikula
2015-02-13 13:01 ` Jarkko Nikula [this message]
2015-02-16 11:49 ` [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from devm_gpiod_get_index() Lee Jones
2015-02-13 13:01 ` [PATCH 3/3] mfd: intel_soc_pmic: Ensure GPIO irq is set to input pin Jarkko Nikula
2015-02-16 11:49 ` Lee Jones
2015-02-16 11:49 ` [PATCH 1/3] mfd: intel_soc_pmic: Move PMIC interrupt comment to probe function Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423832475-5803-2-git-send-email-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=bin.yang@intel.com \
--cc=lee.jones@linaro.org \
--cc=lejun.zhu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox