public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mitchel Humpherys <mitchelh@codeaurora.org>
To: devel@driverdev.osuosl.org,
	Android Kernel Team <kernel-team@android.com>,
	Colin Cross <ccross@android.com>
Cc: linux-kernel@vger.kernel.org,
	Laura Abbott <lauraa@codeaurora.org>,
	John Stultz <john.stultz@linaro.org>,
	Mitchel Humpherys <mitchelh@codeaurora.org>
Subject: [PATCH] ion: improve ion_phys error message
Date: Fri, 13 Feb 2015 18:05:34 -0800	[thread overview]
Message-ID: <1423879534-6961-1-git-send-email-mitchelh@codeaurora.org> (raw)

Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect.  Add the heap name and heap type to
the error message to make it more obvious.

Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
---
 drivers/staging/android/ion/ion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 296d347660fc..966b7fdc9ecf 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -566,8 +566,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
 	buffer = handle->buffer;
 
 	if (!buffer->heap->ops->phys) {
-		pr_err("%s: ion_phys is not implemented by this heap.\n",
-		       __func__);
+		pr_err("%s: ion_phys is not implemented by this heap (name=%s, type=%d).\n",
+			__func__, buffer->heap->name, buffer->heap->type);
 		mutex_unlock(&client->lock);
 		return -ENODEV;
 	}
-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


             reply	other threads:[~2015-02-14  2:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14  2:05 Mitchel Humpherys [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-03-10 17:08 [PATCH] ion: improve ion_phys error message Mitchel Humpherys
2015-03-10 20:46 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423879534-6961-1-git-send-email-mitchelh@codeaurora.org \
    --to=mitchelh@codeaurora.org \
    --cc=ccross@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox