From: Cass May <cass@cassm.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable
Date: Mon, 16 Feb 2015 14:46:35 +0000 [thread overview]
Message-ID: <1424097995.4865.2.camel@cassm.net> (raw)
In-Reply-To: <20150216091222.GX5206@mwanda>
On Mon, 2015-02-16 at 12:12 +0300, Dan Carpenter wrote:
> On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> > Clean up Makefile by removing unnecessary definition of DG_NAME.
> >
> > Signed-off-by: Cass May <cass@cassm.net>
> > ---
> > Having done some build tests, it seems that DG_NAME is not needed,
> > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former,
> > and moved the latter into the appropriate header.
>
> Thanks!
>
> Don't resend; this patch is great. But next time just fold both patches
> together into one patch. It's all part of the same fix really so it
> falls into the "one thing per patch" rule.
>
> regards,
> dan carpenter
Shall do! Thank you for the guidance.
-cass
prev parent reply other threads:[~2015-02-16 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 23:40 [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable Cass May
2015-02-15 23:40 ` [PATCH 2/2] dgnc: Move DG_PART definition from Makefile to dgnc_driver.h Cass May
2015-02-16 9:12 ` [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable Dan Carpenter
2015-02-16 14:46 ` Cass May [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424097995.4865.2.camel@cassm.net \
--to=cass@cassm.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox