Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic

Mark Brown
2015-02-17T01:57:29Z

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Mon, Feb 16, 2015 at 03:41:02PM +0000, Charles Keepax wrote:
> arizona_extcon_do_magic does not lend a lot of clarity to the purpose
> of the function, and as all the registers used are described in the
> datasheet there is no need to obfuscate the code. This patch renames the
> function to arizona_extcon_hp_clamp, as it controls clamping on the
> headphone output.

Probably worth noting that at the time the code was originally
implemented these registers weren't documented.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]