From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756830AbbBQLUT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Feb 2015 06:20:19 -0500
Received: from relay.parallels.com ([195.214.232.42]:35859 "EHLO
	relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754973AbbBQLUS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Feb 2015 06:20:18 -0500
Message-ID: <1424172011.5749.26.camel@tkhai>
Subject: Re: [PATCH 1/2] sched: Move __task_rq_{, un}lock() to
 kernel/sched/sched.h
From: Kirill Tkhai <ktkhai@parallels.com>
To: Peter Zijlstra <peterz@infradead.org>
CC: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        "Josh Poimboeuf" <jpoimboe@redhat.com>
Date: Tue, 17 Feb 2015 14:20:11 +0300
In-Reply-To: <20150217111116.GL5029@twins.programming.kicks-ass.net>
References: <1424170011.5749.20.camel@tkhai>
	 <20150217111116.GL5029@twins.programming.kicks-ass.net>
Organization: Parallels
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.8.5-2+b3 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.24.40.85]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

В Вт, 17/02/2015 в 12:11 +0100, Peter Zijlstra пишет:
> On Tue, Feb 17, 2015 at 01:46:51PM +0300, Kirill Tkhai wrote:
> > 
> > Place it in sched.h, because dl_task_timer() needs it.
> > Also remove lockdep check, which is not fit to this
> > function.
> 
> No, that lockdep check is valid for all current sites.

Sure, but dl_task_timer() do not lock pi_lock. I wanted to delete
"again:" loop in it to simplify second patch.

We can do not touch __task_rq_lock(), and add smp_rmb() in "again:"
loop in second patch instead of this.