From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933143AbbBQOBn (ORCPT ); Tue, 17 Feb 2015 09:01:43 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33340 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933096AbbBQOBl (ORCPT ); Tue, 17 Feb 2015 09:01:41 -0500 Message-ID: <1424181697.2955.6.camel@gmail.com> Subject: Re: 3.14.23-rt20 - aio: fix rcu garbage collection might_sleep() splat From: Mike Galbraith To: Sebastian Andrzej Siewior Cc: Steven Rostedt , LKML , linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Clark Williams Date: Tue, 17 Feb 2015 15:01:37 +0100 In-Reply-To: <20150217125342.GJ26177@linutronix.de> References: <20141031170326.1491a63f@gandalf.local.home> <1414910967.5380.81.camel@marge.simpson.net> <1414913488.5380.115.camel@marge.simpson.net> <20150217125342.GJ26177@linutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-02-17 at 13:53 +0100, Sebastian Andrzej Siewior wrote: > * Mike Galbraith | 2014-11-02 08:31:28 [+0100]: > > >(not pretty) > > You do the RCU thingy and replace locking. Is this required after the > patch I've sent in "Re: [RFC PATCH V2] rt/aio: fix rcu garbage > collection might_sleep() splat"? From a quick browse I've seen that > ffs_epfile_aio_write() invokes kiocb_set_cancel_fn(, ffs_aio_cancel) and > the function does hold a sleeping lock. Yeah, I don't think that's changed, it should still gripe. -Mike