From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts
Date: Tue, 17 Feb 2015 15:02:42 -0800 [thread overview]
Message-ID: <1424214162.25416.9.camel@perches.com> (raw)
In-Reply-To: <20150217145246.e0821f61bcebe2e50b057ef9@linux-foundation.org>
On Tue, 2015-02-17 at 14:52 -0800, Andrew Morton wrote:
> On Tue, 17 Feb 2015 11:44:48 -0800 Joe Perches <joe@perches.com> wrote:
>
> > These functions are soon going to return void
>
> That's news to me.
https://lkml.org/lkml/2014/11/4/393
> > so remove the
> > return value uses.
> >
> > Convert the return value to test seq_has_overflowed() instead.
>
> Why not make seq_printf() return seq_has_overflowed()?
Unnecessary overhead.
> I'm sure it's all very sensible, but the changelogging is poor. Perhaps
> doing all this in a coherent patch series would be a better way.
The changes span too many subsystems.
These could just return 0 for the most part.
next prev parent reply other threads:[~2015-02-17 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 19:44 [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts Joe Perches
2015-02-17 22:52 ` Andrew Morton
2015-02-17 23:02 ` Joe Perches [this message]
2015-02-17 23:16 ` Al Viro
2015-02-18 0:09 ` Joe Perches
2015-02-18 0:27 ` Al Viro
2015-02-18 0:55 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424214162.25416.9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox