From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753076AbbBQXCr (ORCPT ); Tue, 17 Feb 2015 18:02:47 -0500 Received: from smtprelay0056.hostedemail.com ([216.40.44.56]:39870 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752481AbbBQXCq (ORCPT ); Tue, 17 Feb 2015 18:02:46 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:599:800:960:967:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6261:8985:9025:10004:10400:10848:10967:11026:11232:11658:11914:12043:12517:12519:12663:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wheel33_17f860812be56 X-Filterd-Recvd-Size: 1551 Message-ID: <1424214162.25416.9.camel@perches.com> Subject: Re: [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts From: Joe Perches To: Andrew Morton Cc: LKML Date: Tue, 17 Feb 2015 15:02:42 -0800 In-Reply-To: <20150217145246.e0821f61bcebe2e50b057ef9@linux-foundation.org> References: <1424202288.25416.5.camel@perches.com> <20150217145246.e0821f61bcebe2e50b057ef9@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-02-17 at 14:52 -0800, Andrew Morton wrote: > On Tue, 17 Feb 2015 11:44:48 -0800 Joe Perches wrote: > > > These functions are soon going to return void > > That's news to me. https://lkml.org/lkml/2014/11/4/393 > > so remove the > > return value uses. > > > > Convert the return value to test seq_has_overflowed() instead. > > Why not make seq_printf() return seq_has_overflowed()? Unnecessary overhead. > I'm sure it's all very sensible, but the changelogging is poor. Perhaps > doing all this in a coherent patch series would be a better way. The changes span too many subsystems. These could just return 0 for the most part.