public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipmi: Remove uses of return value of seq_printf
Date: Wed, 18 Feb 2015 16:02:53 -0800	[thread overview]
Message-ID: <1424304173.25416.28.camel@perches.com> (raw)
In-Reply-To: <54E4D26B.6020509@acm.org>

On Wed, 2015-02-18 at 11:56 -0600, Corey Minyard wrote:
> Thanks, queued for 3.20.

Hey Corey, thanks, but I'll either have to send a new
patch or an updated patch changing these new
seq_has_overflowed() uses to 0.

There's no functional difference, but there is a logical
one.  has_overflowed(), if it returns "true" (it won't here
because the first alloc seq_fs does has sufficient space)
would not retry and simply not emit anything.

Anyway, do you want a new patch or a relative patch?

sorry 'bout that,  Joe


  reply	other threads:[~2015-02-19  0:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 19:10 [PATCH] ipmi: Remove uses of return value of seq_printf Joe Perches
2015-02-18 17:56 ` Corey Minyard
2015-02-19  0:02   ` Joe Perches [this message]
2015-02-20  3:10     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424304173.25416.28.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox