From: David Ahern <david.ahern@oracle.com>
To: acme@kernel.org, linux-kernel@vger.kernel.org
Cc: David Ahern <david.ahern@oracle.com>
Subject: [PATCH] perf: Fix sigbus with perf-top
Date: Wed, 18 Feb 2015 19:03:18 -0500 [thread overview]
Message-ID: <1424304198-92028-1-git-send-email-david.ahern@oracle.com> (raw)
perf-top is terminating due to SIGBUS on sparc64. git bisect points to:
commit 82396986032915c1572bfb74b224fcc2e4e8ba7c
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Mon Sep 8 13:26:35 2014 -0300
perf evlist: Refcount mmaps
We need to know how many fds are using a perf mmap via
PERF_EVENT_IOC_SET_OUTPUT, so that we can know when to ditch an mmap,
refcount it.
This commit added 'int refcnt' to struct perf_mmap and the addition makes the
event_copy element no longer 8-byte aligned. Fix by adding a pad.
Signed-off-by: David Ahern <david.ahern@oracle.com>
---
tools/perf/util/evlist.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index c94a9e03ecf1..7a5a77b2b907 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -28,6 +28,7 @@ struct perf_mmap {
int mask;
int refcnt;
unsigned int prev;
+ int pad;
char event_copy[PERF_SAMPLE_MAX_SIZE];
};
--
1.9.3
next reply other threads:[~2015-02-19 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:03 David Ahern [this message]
2015-02-25 19:43 ` [PATCH] perf: Fix sigbus with perf-top Arnaldo Carvalho de Melo
2015-03-01 16:50 ` [tip:perf/urgent] perf top: Fix SIGBUS on sparc64 tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424304198-92028-1-git-send-email-david.ahern@oracle.com \
--to=david.ahern@oracle.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox