From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbbBSSWj (ORCPT ); Thu, 19 Feb 2015 13:22:39 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:34215 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbbBSSWi (ORCPT ); Thu, 19 Feb 2015 13:22:38 -0500 Message-ID: <1424370153.18191.12.camel@stgolabs.net> Subject: Re: [PATCH 3/3] tomoyo: robustify handling of mm->exe_file From: Davidlohr Bueso To: Tetsuo Handa Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, takedakn@nttdata.co.jp, linux-security-module@vger.kernel.org Date: Thu, 19 Feb 2015 10:22:33 -0800 In-Reply-To: <201502192007.AFI30725.tHFFOOMVFOQSLJ@I-love.SAKURA.ne.jp> References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-4-git-send-email-dbueso@suse.de> <1424324307.18191.5.camel@stgolabs.net> <201502192007.AFI30725.tHFFOOMVFOQSLJ@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote: > Why do we need to let the caller call path_put() ? > There is no need to do like proc_exe_link() does, for > tomoyo_get_exe() returns pathname as "char *". Having the pathname doesn't guarantee anything later, and thus doesn't seem very robust in the manager call if it can be dropped during the call... or can this never occur in this context?