From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbbBTHa4 (ORCPT ); Fri, 20 Feb 2015 02:30:56 -0500 Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:34255 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753208AbbBTHaz (ORCPT ); Fri, 20 Feb 2015 02:30:55 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3872:3874:4321:5007:6119:6261:7903:8829:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13141:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: lace98_41ee8464b5848 X-Filterd-Recvd-Size: 1922 Message-ID: <1424417451.18211.6.camel@perches.com> Subject: Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma From: Joe Perches To: Tolga Ceylan Cc: Greg Kroah-Hartman , Roxana Blaj , Ana Rey , Rui Miguel Silva , Chaitra Ramaiah , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Larry Finger Date: Thu, 19 Feb 2015 23:30:51 -0800 In-Reply-To: <1424411651-15978-4-git-send-email-tolga.ceylan@gmail.com> References: <1424411651-15978-1-git-send-email-tolga.ceylan@gmail.com> <1424411651-15978-4-git-send-email-tolga.ceylan@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-02-19 at 21:54 -0800, Tolga Ceylan wrote: > Resolved space required after that ',' errors reported by checkpatch. trivia: > diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c [] > @@ -66,7 +66,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > skb = dev_alloc_skb(USB_HWDESC_HEADER_LEN + frag_length + 4); > if (!skb) > return false; > - memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev)); > + memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); Might as well remove the unnecessary cast too: memcpy(skb->cb, &dev, sizeof(dev)); but it might be better to avoid the memcpy and use an assign *(struct net_device *)skb->cb = dev;