From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754497AbbBTNMJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Feb 2015 08:12:09 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:57615 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754356AbbBTNMG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Feb 2015 08:12:06 -0500
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfec7f4-b7f126d000001e9a-4e-54e732126040
Content-transfer-encoding: 8BIT
Message-id: <1424437922.1870.1.camel@AMDC1943>
Subject: Re: [RFT PATCH v2 2/2] compal-laptop: Check return value of
 power_supply_register
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
        Matthew Garrett <matthew.garrett@nebula.com>, stable@vger.kernel.org
Date: Fri, 20 Feb 2015 14:12:02 +0100
In-reply-to: <1424437480-22364-2-git-send-email-k.kozlowski@samsung.com>
References: <1424437480-22364-1-git-send-email-k.kozlowski@samsung.com>
 <1424437480-22364-2-git-send-email-k.kozlowski@samsung.com>
X-Mailer: Evolution 3.10.4-0ubuntu2
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsVy+t/xa7pCRs9DDNbssrZYcqKbxaJroYHF
	5V1z2CyeLDzDZPHxk43F6j0vmC0WbHzE6MDusXPWXXaPzSu0PBZeaWby2Pm9gd3j8ya5ANYo
	LpuU1JzMstQifbsEroymc89YCzo4Kr4f2s/cwHiQrYuRk0NCwETizLOZrBC2mMSFe+uB4lwc
	QgJLGSVOHz7FBJLgFRCU+DH5HksXIwcHs4C8xJFL2SBhZgF1iUnzFjFD1H9mlJj5+BEjRL2e
	xIVT59lBbGGBGInLJ48zg9hsAsYSm5cvAVssAmRPPXkEbBmzwHVGiTn9/8GaWQRUJbYv7GYG
	WcYp4CFx9IkMxIJWRom5v6eDHSEhoCzR2O82gVFgFpLzZiGcNwvJeQsYmVcxiqaWJhcUJ6Xn
	GuoVJ+YWl+al6yXn525ihAT3lx2Mi49ZHWIU4GBU4uH9sedZiBBrYllxZe4hRgkOZiURXk+F
	5yFCvCmJlVWpRfnxRaU5qcWHGJk4OKUaGDlbGnqbtPv8ni088zqRxe6O47z1m/quRIdMP7ls
	skbWx8ldgpaLYnKuPDFwUU43/2yh9dRvdrL7w+e9m42ifySUtEx4Z7KzWf1v0h+mJdtnrXv9
	Wt5eRLXwn/9Oqbs75e9a2nBejKg8s2n+cvEpalcVb83iVzpdfvqXYLmY0toN0VqBduE2P5VY
	ijMSDbWYi4oTASw1bTRMAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On pią, 2015-02-20 at 14:04 +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
> 
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
> 
> Fix this by checking return status of power_supply_register() call. In
> case of failure, clean up sysfs entries and fail the probe.
> 

(...)

>  
> @@ -1072,6 +1074,7 @@ static int compal_remove(struct platform_device *pdev)
>  
>  	data = platform_get_drvdata(pdev);
>  	power_supply_unregister(&data->psy);
> +	/* FIXME: missing hwmon_device_unregister() */
>  
>  	sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group);


Crap, I forgot to remove the FIXME note. It is no longer needed because
patch 1 fixes this.

I'll resend. Sorry for the noise.