From: Joe Perches <joe@perches.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roxana Blaj <roxanagabriela10@gmail.com>,
Ana Rey <anarey@gmail.com>, Rui Miguel Silva <rmfrfs@gmail.com>,
Chaitra Ramaiah <linux.delve@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma
Date: Fri, 20 Feb 2015 17:59:37 -0800 [thread overview]
Message-ID: <1424483977.18211.23.camel@perches.com> (raw)
In-Reply-To: <CALmu+Sz85C-aqst6o2hiDJ_y9JNRum=6p4rcaz8DSSv2nmpU2g@mail.gmail.com>
On Fri, 2015-02-20 at 16:31 -0800, Tolga Ceylan wrote:
> On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan <tolga.ceylan@gmail.com> wrote:
> > On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches <joe@perches.com> wrote:
> >> Might as well remove the unnecessary cast too:
> >> memcpy(skb->cb, &dev, sizeof(dev));
> >> but it might be better to avoid the memcpy and use an assign
> >> *(struct net_device *)skb->cb = dev;
[]
> Should I sent a new set of patches (including memcpy change)?
> Or reply to the series with a single memcpy change patch?
Let Larry Finger decide if he wants the
patches at all first.
next prev parent reply other threads:[~2015-02-21 1:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 5:54 [PATCH 1/4] Staging: rtl8192u: r819xU_firmware: removed commented out variable Tolga Ceylan
2015-02-20 5:54 ` [PATCH 2/4] Staging: rtl8192u: r819xU_firmware: removed commented out assert Tolga Ceylan
2015-02-20 5:54 ` [PATCH 3/4] Staging: rtl9182u: r819xU_firmware: Replaced C99 comments with C89 Tolga Ceylan
2015-02-20 5:54 ` [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma Tolga Ceylan
2015-02-20 7:30 ` Joe Perches
2015-02-20 19:47 ` Tolga Ceylan
2015-02-21 0:31 ` Tolga Ceylan
2015-02-21 1:59 ` Joe Perches [this message]
2015-03-07 0:57 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424483977.18211.23.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=anarey@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.delve@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=roxanagabriela10@gmail.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox