Re: [PATCH 2/6] CRIS: remove SMP code

[Paul Bolle <pebolle@tiscali.nl>]

On Sat, 2015-02-21 at 01:40 +0100, Rabin Vincent wrote:
> On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote:
> > On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote:
> > > The CRIS SMP code cannot be built since there is no (and appears to
> > > never have been) a CONFIG_SMP Kconfig option in arch/cris/.  Remove it.
> > 
> > Yes, it appears there never was a Kconfig symbol SMP for cris so this
> > probably was dead code ever since it was added in, I think, v2.6.13. (I
> > should mention I didn't review this patch, or cris' apparently
> > non-functional SMP code, in detail.)
> > 
> > Mind if I ask how you spotted this?
> 
> If you're asking if I used some kind of script, no, I didn't.  I just
> noticed it while working on other CRIS patches. 

Yes. See, I run a script locally. It is rather simple and only catches
the more obvious kconfig related mistakes. I'm pretty sure I won't
bother teaching it to spot mistakes like this one. But other people are
working on a sophisticated bot that might be able to catch those.

But, anyhow, just paying attention when fiddling with a piece of code
and spotting possible oddities is of course greatly appreciated!


Paul Bolle