From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
Lee Jones <lee@kernel.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 0/1] clkdev: prevent potential memory leak when used in modules
Date: Mon, 23 Feb 2015 13:49:40 +0200 [thread overview]
Message-ID: <1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
Since clk_register_clkdev() is exported for modules the caller should get a
pointer to the allocated resources. Otherwise the memory leak is guaranteed on
the ->remove() stage.
The patch changes the prototype of the clk_register_clkdev() to return a
pointer to the allocated resources. The caller should take care of the returned
variable and free allocated resources when needed. Together with the main
change the users are updated too.
The current change doesn't fix any present memory leak, thus developers and
maintainers should take care of it if needed.
The patch has been tested on x86 (*), thus requires to be tested on touched
architectures.
(*) On x86 there is no upstream users yet, though we have one pending.
Changelog v2:
- update inplace documentation to mention clkdev_drop() that should be used to
free the resources
- mention in cover letter that we have tested it on x86
- append Mika's Reviewed-by tag
- add Russel to the Cc list
- rebase on top of 4.0-rc1
Andy Shevchenko (1):
clkdev: change prototype of clk_register_clkdev()
arch/arm/mach-msm/clock-pcom.c | 9 +++++----
arch/arm/mach-vexpress/spc.c | 5 ++++-
arch/mips/ath79/clock.c | 6 +++---
drivers/clk/clk-bcm2835.c | 12 +++++++-----
drivers/clk/clk-max-gen.c | 9 ++++-----
drivers/clk/clk-xgene.c | 6 +++---
drivers/clk/clkdev.c | 15 ++++++++++-----
drivers/clk/samsung/clk-pll.c | 13 ++++++++-----
drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++---------
drivers/clk/samsung/clk.c | 35 +++++++++++++++++++---------------
include/linux/clkdev.h | 2 +-
11 files changed, 75 insertions(+), 56 deletions(-)
--
2.1.4
next reply other threads:[~2015-02-23 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:49 Andy Shevchenko [this message]
2015-02-23 11:49 ` [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev() Andy Shevchenko
2015-02-23 11:53 ` Lee Jones
2015-02-23 11:57 ` Andy Shevchenko
2015-02-23 12:02 ` Andy Shevchenko
2015-02-23 12:03 ` Russell King - ARM Linux
2015-02-23 12:23 ` Lee Jones
2015-02-23 12:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bryanh@codeaurora.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@linaro.org \
--cc=ralf@linux-mips.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox