From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752906AbbBWMCo (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 07:02:44 -0500
Received: from mga01.intel.com ([192.55.52.88]:25526 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752241AbbBWMCm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 07:02:42 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,630,1418112000"; 
   d="scan'208";a="655816231"
Message-ID: <1424692951.14897.0.camel@linux.intel.com>
Subject: Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev()
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
        Mike Turquette <mturquette@linaro.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Date: Mon, 23 Feb 2015 14:02:31 +0200
In-Reply-To: <20150223115356.GA21609@x1>
References: <1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com>
	 <20150223115356.GA21609@x1>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-02-23 at 11:53 +0000, Lee Jones wrote:
> On Mon, 23 Feb 2015, Andy Shevchenko wrote:
> 
> > Since clk_register_clkdev() is exported for modules the caller should get a
> > pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> > the ->remove() stage.
> > 
> > Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/arm/mach-msm/clock-pcom.c         |  9 +++++----
> >  arch/arm/mach-vexpress/spc.c           |  5 ++++-
> >  arch/mips/ath79/clock.c                |  6 +++---
> >  drivers/clk/clk-bcm2835.c              | 12 +++++++-----
> >  drivers/clk/clk-max-gen.c              |  9 ++++-----
> >  drivers/clk/clk-xgene.c                |  6 +++---
> >  drivers/clk/clkdev.c                   | 15 ++++++++++-----
> >  drivers/clk/samsung/clk-pll.c          | 13 ++++++++-----
> >  drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++---------
> >  drivers/clk/samsung/clk.c              | 35 +++++++++++++++++++---------------
> >  include/linux/clkdev.h                 |  2 +-
> >  11 files changed, 75 insertions(+), 56 deletions(-)
> 
> What's tying all of these changes together?  It would be better
> (simpler for you) if you split them up by subsystem and resubmitted.

In that case it will break bisectability.


-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy