From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbBWMhE (ORCPT ); Mon, 23 Feb 2015 07:37:04 -0500 Received: from mga02.intel.com ([134.134.136.20]:9553 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbBWMhC (ORCPT ); Mon, 23 Feb 2015 07:37:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,630,1418112000"; d="scan'208";a="655827380" Message-ID: <1424695015.14897.5.camel@linux.intel.com> Subject: Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev() From: Andy Shevchenko To: Lee Jones Cc: Russell King - ARM Linux , linux-kernel@vger.kernel.org, Stephen Boyd , Mike Turquette , Bryan Huntsman , Lorenzo Pieralisi , Ralf Baechle , Sylwester Nawrocki , Tomeu Vizoso Date: Mon, 23 Feb 2015 14:36:55 +0200 In-Reply-To: <20150223122309.GB21609@x1> References: <1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com> <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com> <20150223115356.GA21609@x1> <20150223120329.GN8656@n2100.arm.linux.org.uk> <20150223122309.GB21609@x1> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-23 at 12:23 +0000, Lee Jones wrote: > On Mon, 23 Feb 2015, Russell King - ARM Linux wrote: > > > On Mon, Feb 23, 2015 at 11:53:56AM +0000, Lee Jones wrote: > > > On Mon, 23 Feb 2015, Andy Shevchenko wrote: > > > > arch/arm/mach-msm/clock-pcom.c | 9 +++++---- > > > > arch/arm/mach-vexpress/spc.c | 5 ++++- > > > > arch/mips/ath79/clock.c | 6 +++--- > > > > drivers/clk/clk-bcm2835.c | 12 +++++++----- > > > > drivers/clk/clk-max-gen.c | 9 ++++----- > > > > drivers/clk/clk-xgene.c | 6 +++--- > > > > drivers/clk/clkdev.c | 15 ++++++++++----- > > > > drivers/clk/samsung/clk-pll.c | 13 ++++++++----- > > > > drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++--------- > > > > drivers/clk/samsung/clk.c | 35 +++++++++++++++++++--------------- > > > > include/linux/clkdev.h | 2 +- > > > > 11 files changed, 75 insertions(+), 56 deletions(-) > > > > > > What's tying all of these changes together? It would be better > > > (simpler for you) if you split them up by subsystem and resubmitted. > > > > I think maybe, just maybe, you might get the answer to that if you read > > the patch. > > > > You can't change the function signature without creating lots of warnings > > and causing regressions. > > > > Yes, the function could be renamed whilst doing this change, but that's > > really quite sub-standard in an already busy namespace. > > Okay, I can go with that. > > If I'm reading this patch correctly, it doesn't actually fix > anything. Right. Consider this as a stage 1 that allows you to make a proper fix on an actual use case. > What's the thinking behind stopping short? Why don't you go > the extra inch and free the resources at the appropriate times? As far as I can see most of the cases are for whole OS time to live, means no need to free resources. The really affected users should know by themselves and I'm not going to brainlessly fix every usage of the clkdev_register() (note most of them [> 90% use cases?] even didn't check the return code). -- Andy Shevchenko Intel Finland Oy