From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752420AbbBXEyr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 23:54:47 -0500
Received: from smtprelay0131.hostedemail.com ([216.40.44.131]:48785 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751812AbbBXEyp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 23:54:45 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:4321:5007:6261:7514:7903:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12517:12519:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: trail52_636c94762bb40
X-Filterd-Recvd-Size: 2203
Message-ID: <1424753682.5342.9.camel@perches.com>
Subject: Re: [PATCH] drivers: media: i2c : s5c73m3: Replace dev_err with
 pr_err
From: Joe Perches <joe@perches.com>
To: Tapasweni Pathak <tapaswenipathak@gmail.com>
Cc: kyungmin.park@samsung.com, a.hajda@samsung.com, mchehab@osg.samsung.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 23 Feb 2015 20:54:42 -0800
In-Reply-To: <20150224044731.GA5804@kt-Inspiron-3542>
References: <20150224044731.GA5804@kt-Inspiron-3542>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-02-24 at 10:17 +0530, Tapasweni Pathak wrote:
> Replace dev_err statement with pr_err to fix null dereference.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> ---
>  drivers/media/i2c/s5c73m3/s5c73m3-spi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> index f60b265..63eb190 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> @@ -52,7 +52,7 @@ static int spi_xmit(struct spi_device *spi_dev, void *addr, const int len,
>  		xfer.rx_buf = addr;
> 
>  	if (spi_dev == NULL) {
> -		dev_err(&spi_dev->dev, "SPI device is uninitialized\n");
> +		pr_err("SPI device is uninitialized\n");
>  		return -ENODEV;
>  	}

It'd be better to move this above the if (dir...) block
and use ratelimit/once it too

static int spi_xmit(struct spi_device *spi_dev, void *addr, const int len,
		    enum spi_direction dir)
{
	struct spi_message msg;
	int r;
	struct spi_transfer xfer = {
		.len	= len,
	};

	if (!spi_dev) {
		pr_err_once("SPI device is uninitialized\n");
		return -ENODEV;
	}

	if (dir == SPI_DIR_TX)
		xfer.tx_buf = addr;
	else
		xfer.rx_buf = addr;

	...