From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbbBXHuV (ORCPT ); Tue, 24 Feb 2015 02:50:21 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:27067 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbbBXHuQ (ORCPT ); Tue, 24 Feb 2015 02:50:16 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-b2-54ec2ca480e5 Content-transfer-encoding: 8BIT Message-id: <1424764212.7479.4.camel@AMDC1943> Subject: Re: [PATCH 2/2] mfd: sec: Cleanup unused RTC fields: ono, WTSR and SMPL From: Krzysztof Kozlowski To: Lee Jones Cc: Sangbeom Kim , Samuel Ortiz , Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Kyungmin Park , Bartlomiej Zolnierkiewicz , Marek Szyprowski , akpm@linux-foundation.org Date: Tue, 24 Feb 2015 08:50:12 +0100 In-reply-to: <1423221888-32052-3-git-send-email-k.kozlowski@samsung.com> References: <1423221888-32052-1-git-send-email-k.kozlowski@samsung.com> <1423221888-32052-3-git-send-email-k.kozlowski@samsung.com> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xy7pLdN6EGEzs1bVYcvEqu8Wc9WvY LDbOWM9qcbbpDbvF/a9HGS0u75rDZrH2yF12i/2dHYwWp7tZLS6u+MLkwOWxZ+JJNo871/aw eZyY8ZvFY97JQI++LasYPabP+8nk8XmTXAB7FJdNSmpOZllqkb5dAlfGsZ/vGQtui1ds/Rrb wPhAqIuRk0NCwETi9oGlLBC2mMSFe+vZuhi5OIQEljJKtOxvZAVJ8AoISvyYfA+oiIODWUBe 4silbJAws4C6xKR5i5gh6j8zSpy/cowZol5PovfYCkYQW1ggQOL50m1MIDabgLHE5uVL2EDm iAioSJx7Yw7SyyzwgEni8M1pbCA1LAKqEr2nZoHt5RTwkJgzYxILxIJWRon7n2cxgzRLCChL NPa7TWAUmIXkvFkI581Cct4CRuZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCHx8GUH4+Jj VocYBTgYlXh4H5S9ChFiTSwrrsw9xCjBwawkwpv29HWIEG9KYmVValF+fFFpTmrxIUYmDk6p BkYl0dInjH5yx9pNWze8flO88NFPDs/9BVluQl6rHc53cORGaV/9rJS6bNWvntbeuaeiNxSs VD36ojd/xrZnopyWuTVHD3u//2baP2Xj7umbSyRXNU3kPpL/2Lmi+IUrX/65nYxFBRlPlvOF LWiImOSdu4Q5fkUMi22L866AUH/7ZwlntLcXn1NiKc5INNRiLipOBAA/JxGnZQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2015-02-06 at 12:24 +0100, Krzysztof Kozlowski wrote: > The WTSR (Watchdog Timer Software Reset) and SMPL (Sudden Momentary > Power Loss) were removed from rtc-s5m driver because they were not used. > Remove them (and on/off interrupt) from main MFD driver and header. > > Additionally remove ENOMEM error message. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/sec-core.c | 5 +---- > include/linux/mfd/samsung/core.h | 9 --------- > 2 files changed, 1 insertion(+), 13 deletions(-) Dear Lee, This patch depends on 1/2 which was picked by Andrew Morton: http://ozlabs.org/~akpm/mmots/broken-out/rtc-s5m-remove-unused-watchdog-and-sudden-momentary-power-loss.patch If this looks OK to you, maybe you could ack it and this patch would also go through Andrew's tree? Best regards, Krzysztof > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 0a7bc43db4e4..2253d44e631c 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -267,10 +267,8 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata( > struct sec_platform_data *pd; > > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > - if (!pd) { > - dev_err(dev, "could not allocate memory for pdata\n"); > + if (!pd) > return ERR_PTR(-ENOMEM); > - } > > /* > * ToDo: the 'wakeup' member in the platform data is more of a linux > @@ -333,7 +331,6 @@ static int sec_pmic_probe(struct i2c_client *i2c, > } > if (pdata) { > sec_pmic->device_type = pdata->device_type; > - sec_pmic->ono = pdata->ono; > sec_pmic->irq_base = pdata->irq_base; > sec_pmic->wakeup = pdata->wakeup; > sec_pmic->pdata = pdata; > diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h > index 3fdb7cfbffb3..75115384f3fc 100644 > --- a/include/linux/mfd/samsung/core.h > +++ b/include/linux/mfd/samsung/core.h > @@ -58,13 +58,7 @@ enum sec_device_type { > * @irq_base: Base IRQ number for device, required for IRQs > * @irq: Generic IRQ number for device > * @irq_data: Runtime data structure for IRQ controller > - * @ono: Power onoff IRQ number for s5m87xx > * @wakeup: Whether or not this is a wakeup device > - * @wtsr_smpl: Whether or not to enable in RTC driver the Watchdog > - * Timer Software Reset (registers set to default value > - * after PWRHOLD falling) and Sudden Momentary Power Loss > - * (PMIC will enter power on sequence after short drop in > - * VBATT voltage). > */ > struct sec_pmic_dev { > struct device *dev; > @@ -77,9 +71,7 @@ struct sec_pmic_dev { > int irq; > struct regmap_irq_chip_data *irq_data; > > - int ono; > bool wakeup; > - bool wtsr_smpl; > }; > > int sec_irq_init(struct sec_pmic_dev *sec_pmic); > @@ -95,7 +87,6 @@ struct sec_platform_data { > int irq_base; > int (*cfg_pmic_irq)(void); > > - int ono; > bool wakeup; > bool buck_voltage_lock; >