public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Hung <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
	peter_hong@fintek.com.tw, hpeter@gmail.com,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: [PATCH V7 02/11] USB: f81232: add preparatory functions
Date: Tue, 24 Feb 2015 18:16:17 +0800	[thread overview]
Message-ID: <1424772986-5542-3-git-send-email-hpeter+linux_kernel@gmail.com> (raw)
In-Reply-To: <1424772986-5542-1-git-send-email-hpeter+linux_kernel@gmail.com>

We add f81232_get_register()/f81232_set_register() and necessary defines
for future patch with communication with F81232 USB control endpoint.

Because of this is a preparatory patch, there are unused function warning
with compiling. The functions will used with following patches.

Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
---
 drivers/usb/serial/f81232.c | 79 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 669a2f2..1f29b95 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -30,6 +30,11 @@ static const struct usb_device_id id_table[] = {
 };
 MODULE_DEVICE_TABLE(usb, id_table);
 
+/* USB Control EP parameter */
+#define F81232_REGISTER_REQUEST	0xA0
+#define F81232_GET_REGISTER	0xc0
+#define F81232_SET_REGISTER	0x40
+
 #define CONTROL_DTR			0x01
 #define CONTROL_RTS			0x02
 
@@ -50,6 +55,80 @@ struct f81232_private {
 	u8 modem_status;
 };
 
+static int f81232_get_register(struct usb_serial_port *port, u16 reg, u8 *data)
+{
+	int status;
+	u8 *tmp;
+	struct usb_device *dev = port->serial->dev;
+
+	if (!data)
+		return -EFAULT;
+
+	tmp = kmalloc(sizeof(u8), GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	status = usb_control_msg(dev,
+				usb_rcvctrlpipe(dev, 0),
+				F81232_REGISTER_REQUEST,
+				F81232_GET_REGISTER,
+				reg,
+				0,
+				tmp,
+				sizeof(u8),
+				USB_CTRL_GET_TIMEOUT);
+	if (status <= 0) {
+		/* show something with failed */
+		dev_err(&port->dev, "%s failed status: %d\n", __func__, status);
+
+		if (status == 0)
+			status = -EIO;
+		else
+			status = usb_translate_errors(status);
+	} else {
+		status = 0; /* on success */
+		memcpy((void*) data, (void*) tmp, sizeof(u8));
+	}
+
+	kfree(tmp);
+	return status;
+}
+
+static int f81232_set_register(struct usb_serial_port *port, u16 reg, u8 data)
+{
+	int status;
+	u8 *tmp;
+	struct usb_device *dev = port->serial->dev;
+
+	tmp = kmalloc(sizeof(u8), GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	memcpy((void*) tmp, (void*) &data, sizeof(u8));
+
+	status = usb_control_msg(dev,
+				usb_sndctrlpipe(dev, 0),
+				F81232_REGISTER_REQUEST,
+				F81232_SET_REGISTER,
+				reg,
+				0,
+				tmp,
+				sizeof(u8),
+				USB_CTRL_SET_TIMEOUT);
+	if (status <= 0) {
+		/* show something with failed */
+		dev_err(&port->dev, "%s failed status: %d\n", __func__, status);
+
+		if (status == 0)
+			status = -EIO;
+		else
+			status = usb_translate_errors(status);
+	} else
+		status = 0; /* on success */
+
+	kfree(tmp);
+	return status;
+}
 static void f81232_update_line_status(struct usb_serial_port *port,
 				      unsigned char *data,
 				      unsigned int actual_length)
-- 
1.9.1


  parent reply	other threads:[~2015-02-24 10:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 10:16 [PATCH V7 00/11] USB: f81232: V7 patches Peter Hung
2015-02-24 10:16 ` [PATCH V7 01/11] USB: f81232: rename private struct member name Peter Hung
2015-02-24 10:16 ` Peter Hung [this message]
2015-02-25  6:30   ` [PATCH V7 02/11] USB: f81232: add preparatory functions Johan Hovold
2015-02-24 10:16 ` [PATCH V7 03/11] USB: f81232: implement RX bulk-in EP Peter Hung
2015-02-25  6:40   ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 04/11] USB: f81232: change lock mechanism Peter Hung
2015-02-24 10:16 ` [PATCH V7 05/11] USB: f81232: implement read IIR/MSR with endpoint Peter Hung
2015-02-25  6:53   ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 06/11] USB: f81232: implement MCR/MSR function Peter Hung
2015-02-25  7:02   ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 07/11] USB: f81232: implement port_enable function Peter Hung
2015-02-25  7:11   ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 08/11] USB: f81232: implement set_termios() Peter Hung
2015-02-25  7:52   ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 09/11] USB: f81232: clarify f81232_ioctl() and fix Peter Hung
2015-02-24 10:16 ` [PATCH V7 10/11] USB: f81232: cleanup non-used define Peter Hung
2015-02-24 10:16 ` [PATCH V7 11/11] USB: f81232: modify/add author Peter Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424772986-5542-3-git-send-email-hpeter+linux_kernel@gmail.com \
    --to=hpeter@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox