From: Peter Hung <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw, hpeter@gmail.com,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: [PATCH V7 07/11] USB: f81232: implement port_enable function
Date: Tue, 24 Feb 2015 18:16:22 +0800 [thread overview]
Message-ID: <1424772986-5542-8-git-send-email-hpeter+linux_kernel@gmail.com> (raw)
In-Reply-To: <1424772986-5542-1-git-send-email-hpeter+linux_kernel@gmail.com>
We put FCR/IER initial step to f81232_port_enable(). When port is open,
it set MSR interrupt on. Otherwise set it off.
Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
---
drivers/usb/serial/f81232.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 21f606f..f5c9060 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -37,6 +37,8 @@ MODULE_DEVICE_TABLE(usb, id_table);
#define F81232_SET_REGISTER 0x40
#define SERIAL_BASE_ADDRESS 0x0120
+#define INTERRUPT_ENABLE_REGISTER (0x01 + SERIAL_BASE_ADDRESS)
+#define FIFO_CONTROL_REGISTER (0x02 + SERIAL_BASE_ADDRESS)
#define MODEM_CONTROL_REGISTER (0x04 + SERIAL_BASE_ADDRESS)
#define MODEM_STATUS_REGISTER (0x06 + SERIAL_BASE_ADDRESS)
@@ -367,6 +369,33 @@ static void f81232_break_ctl(struct tty_struct *tty, int break_state)
*/
}
+static int f81232_port_enable(struct usb_serial_port *port, int enable)
+{
+ u8 data = 0;
+ int status;
+
+ /* fifo on, trigger8, clear TX/RX*/
+ data = UART_FCR_TRIGGER_8 | UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR
+ | UART_FCR_CLEAR_XMIT;
+
+ status = f81232_set_register(port, FIFO_CONTROL_REGISTER, data);
+ if (status) {
+ dev_err(&port->dev, "%s failed to set FCR: %d\n", __func__, status);
+ return status;
+ }
+
+ /* MSR Interrupt only, LSR will read from Bulk-in odd byte */
+ data = enable ? UART_IER_MSI : 0;
+
+ status = f81232_set_register(port, INTERRUPT_ENABLE_REGISTER, data);
+ if (status) {
+ dev_err(&port->dev, "%s failed to set IER: %d\n", __func__, status);
+ return status;
+ }
+
+ return 0;
+}
+
static void f81232_set_termios(struct tty_struct *tty,
struct usb_serial_port *port, struct ktermios *old_termios)
{
@@ -418,6 +447,12 @@ static int f81232_open(struct tty_struct *tty, struct usb_serial_port *port)
{
int result;
+ result = f81232_port_enable(port, 1);
+ if (result) {
+ dev_err(&port->dev, "%s - init fail: %d\n", __func__, result);
+ return result;
+ }
+
/* Setup termios */
if (tty)
f81232_set_termios(tty, port, NULL);
@@ -440,6 +475,10 @@ static int f81232_open(struct tty_struct *tty, struct usb_serial_port *port)
static void f81232_close(struct usb_serial_port *port)
{
+ int result = f81232_port_enable(port, 0);
+ if (result)
+ dev_err(&port->dev, "%s - init fail: %d\n", __func__, result);
+
usb_serial_generic_close(port);
usb_kill_urb(port->interrupt_in_urb);
}
--
1.9.1
next prev parent reply other threads:[~2015-02-24 10:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 10:16 [PATCH V7 00/11] USB: f81232: V7 patches Peter Hung
2015-02-24 10:16 ` [PATCH V7 01/11] USB: f81232: rename private struct member name Peter Hung
2015-02-24 10:16 ` [PATCH V7 02/11] USB: f81232: add preparatory functions Peter Hung
2015-02-25 6:30 ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 03/11] USB: f81232: implement RX bulk-in EP Peter Hung
2015-02-25 6:40 ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 04/11] USB: f81232: change lock mechanism Peter Hung
2015-02-24 10:16 ` [PATCH V7 05/11] USB: f81232: implement read IIR/MSR with endpoint Peter Hung
2015-02-25 6:53 ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 06/11] USB: f81232: implement MCR/MSR function Peter Hung
2015-02-25 7:02 ` Johan Hovold
2015-02-24 10:16 ` Peter Hung [this message]
2015-02-25 7:11 ` [PATCH V7 07/11] USB: f81232: implement port_enable function Johan Hovold
2015-02-24 10:16 ` [PATCH V7 08/11] USB: f81232: implement set_termios() Peter Hung
2015-02-25 7:52 ` Johan Hovold
2015-02-24 10:16 ` [PATCH V7 09/11] USB: f81232: clarify f81232_ioctl() and fix Peter Hung
2015-02-24 10:16 ` [PATCH V7 10/11] USB: f81232: cleanup non-used define Peter Hung
2015-02-24 10:16 ` [PATCH V7 11/11] USB: f81232: modify/add author Peter Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424772986-5542-8-git-send-email-hpeter+linux_kernel@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox