Re: [PATCH 07/13] x86/microcode/intel: Rename update_match_revision()

Quentin Casasnovas
2015-02-24T16:21:32Z

On Tue, Feb 24, 2015 at 11:37:06AM +0100, Borislav Petkov wrote:
> +++ b/arch/x86/include/asm/microcode_intel.h
> @@ -60,8 +60,12 @@ extern int
> get_matching_microcode(unsigned int csig, int cpf, void *mc, int rev);
> extern int microcode_sanity_check(void *mc, int print_err);
> extern int get_matching_sig(unsigned int csig, int cpf, void *mc, int rev);
> -extern int
> -update_match_revision(struct microcode_header_intel *mc_header, int rev);
> +
> +static inline int
> +revision_is_newer(struct microcode_header_intel *mc_header, int rev)
> +{
> + return (mc_header->rev <= rev) ? 0 : 1;
> +}
>

Minor nit-pick, if you reverse your inequality, you don't need for the
ternary operator.

Quentin