Re: [PATCH 04/13] x86/microcode/intel: Simplify load_ucode_intel_bsp()

Borislav Petkov
2015-02-24T18:31:31Z

On Tue, Feb 24, 2015 at 05:21:51PM +0100, Quentin Casasnovas wrote:
> ... here `size = end - start + 1`, so basically the original size in
> `hdr.ramdisk_image` *plus one*, whereas the `size` you're passing around
> does not include it. I'm not saying it's wrong, quite the opposite I think
> you're fixing an off-by-one error present in the original code at the same
> time :)

I know, right :-)

I was scratching my head about it and if using the size directly is
wrong then something's genuinely b0rked with the design of this thing.

I'll correct the commit message.

Tanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--