From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org,
linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, galak@codeaurora.org,
agross@codeaurora.org
Subject: Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2
Date: Tue, 24 Feb 2015 13:01:08 +0200 [thread overview]
Message-ID: <1424775668.2340.15.camel@mm-sol.com> (raw)
In-Reply-To: <1424386453-18092-3-git-send-email-gavidov@codeaurora.org>
Hi Gilad,
One more comment :-).
On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:
<snip>
-static int pmic_arb_wait_for_done(struct spmi_controller *ctrl)
+static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
+ void __iomem *base, u8 sid, u16 addr)
{
struct spmi_pmic_arb_dev *dev = spmi_controller_get_drvdata(ctrl);
u32 status = 0;
u32 timeout = PMIC_ARB_TIMEOUT_US;
- u32 offset = PMIC_ARB_STATUS(dev->channel);
+ u32 offset = dev->ver_ops->offset(dev, sid, addr) + PMIC_ARB_STATUS;
while (timeout--) {
status = pmic_arb_base_read(dev, offset);
I see that downstream driver is using read or write base address
based on operation for which we are waiting (read_cmd/write_cmd).
Should this be reflected here?
Ivan.
next prev parent reply other threads:[~2015-02-24 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 22:54 [PATCH V4 0/2] [PATCH V4 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-02-19 22:54 ` [PATCH V4 1/2] spmi: remove wakeup command before slave probe Gilad Avidov
2015-02-19 22:54 ` [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-02-23 9:59 ` Ivan T. Ivanov
2015-03-10 10:51 ` Ivan T. Ivanov
2015-03-11 23:43 ` Gilad Avidov
2015-02-23 16:06 ` Ivan T. Ivanov
2015-03-11 22:55 ` Gilad Avidov
2015-02-24 11:01 ` Ivan T. Ivanov [this message]
2015-03-11 19:05 ` Gilad Avidov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424775668.2340.15.camel@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox