From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbbBXPms (ORCPT ); Tue, 24 Feb 2015 10:42:48 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:56856 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbbBXPmr (ORCPT ); Tue, 24 Feb 2015 10:42:47 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-5f-54ec9b600bc1 Message-id: <1424792562.6775.3.camel@AMDC1943> Subject: Re: [PATCH] ARM: EXYNOS: Handle of_find_device_by_node and kstrdup failures From: Krzysztof Kozlowski To: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Bartlomiej Zolnierkiewicz , Marek Szyprowski Date: Tue, 24 Feb 2015 16:42:42 +0100 In-reply-to: <1422984529-17729-1-git-send-email-k.kozlowski@samsung.com> References: <1422984529-17729-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOLMWRmVeSWpSXmKPExsVy+t/xK7oJs9+EGNw4ymKxccZ6Vov+x6+Z Lc42vWG32PT4GqvF5V1z2CxmnN/HZLH2yF12B3aPTas62Tw2L6n36NuyitHj8ya5AJYoLpuU 1JzMstQifbsEroz3l+8yFhzgrZjSPomxgfE6VxcjJ4eEgInErLdXWCBsMYkL99azdTFycQgJ LGWU+LBiGzOE85lR4uiMPmaQKl4BPYlnDTPYQWxhgTCJWe+bWEFsNgFjic3LlwB1c3CICChK bF6gANLLLPCXUWJ3y3ZGkBoWAVWJt7veMoHYnAIeEutmbQfbLCTgLjHjeTvYHGYBdYlJ8xYx g8yREFCWaOx3g1grKPFj8j0WiBJ5ic1r3jJPYBSYhaRjFpKyWUjKFjAyr2IUTS1NLihOSs81 0itOzC0uzUvXS87P3cQICeyvOxiXHrM6xCjAwajEw/ug7FWIEGtiWXFl7iFGCQ5mJRFeualv QoR4UxIrq1KL8uOLSnNSiw8xMnFwSjUwrg5VmHhW1SwkWjjiu19m+4ZzRiaVp2yu6/0xzDm4 7rvrBxWpdZn1K220vzrc3x46y8to3Zl5uc12TmHq6jWlG0o8t8s9YC28lJCUo8x0zu5awuk+ dY3wjf8seN1e9wrst+y9Wipdd/njqm8/+40PTls686XIhHfLXJ3WNH7RF07e4/VituozJZbi jERDLeai4kQAjAwppUoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On wto, 2015-02-03 at 18:28 +0100, Krzysztof Kozlowski wrote: > Prevent possible NULL pointer dereference of pointer returned by > of_find_device_by_node(). Handle this by skipping such power domain. > > Additionally fail the init on kstrdup() failure. Such case is actually > not fatal because the name for power domain allocated by kstrdup() is > used only in printk. Still as a precaution handle this as an error > condition. > > Signed-off-by: Krzysztof Kozlowski Hi Kukjin, What is the status of this patch and the "ARM: EXYNOS: Handle of of_iomap() failure". The latter should be in your tree but I cannot find it. Best regards, Krzysztof > --- > arch/arm/mach-exynos/pm_domains.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c > index fd7640a6b503..4c6c29ba58ef 100644 > --- a/arch/arm/mach-exynos/pm_domains.c > +++ b/arch/arm/mach-exynos/pm_domains.c > @@ -116,6 +116,12 @@ static __init int exynos4_pm_init_power_domain(void) > struct device *dev; > > pdev = of_find_device_by_node(np); > + if (!pdev) { > + pr_err("%s: failed to find device for node %s\n", > + __func__, np->name); > + of_node_put(np); > + continue; > + } > dev = &pdev->dev; > > pd = kzalloc(sizeof(*pd), GFP_KERNEL); > @@ -126,6 +132,12 @@ static __init int exynos4_pm_init_power_domain(void) > } > > pd->pd.name = kstrdup(np->name, GFP_KERNEL); > + if (!pd->pd.name) { > + kfree(pd); > + of_node_put(np); > + return -ENOMEM; > + } > + > pd->name = pd->pd.name; > pd->base = of_iomap(np, 0); > if (!pd->base) {