* [PATCH] phy: exynos-mipi-video: Fixup the test for state->regmap
@ 2015-02-26 3:48 Axel Lin
2015-02-26 9:47 ` Sylwester Nawrocki
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-02-26 3:48 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Sylwester Nawrocki, Kyungmin Park,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
syscon_regmap_lookup_by_phandle() returns ERR_PTR on error.
Thus don't use null test against state->regmap.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-exynos-mipi-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index f017b2f..d196493 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -59,7 +59,7 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
else
reset = EXYNOS4_MIPI_PHY_SRESETN;
- if (state->regmap) {
+ if (!IS_ERR(state->regmap)) {
mutex_lock(&state->mutex);
regmap_read(state->regmap, offset, &val);
if (on)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 3:48 [PATCH] phy: exynos-mipi-video: Fixup the test for state->regmap Axel Lin
2015-02-26 9:47 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox