From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbbBZJLb (ORCPT ); Thu, 26 Feb 2015 04:11:31 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:61641 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbBZJL2 (ORCPT ); Thu, 26 Feb 2015 04:11:28 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-a0-54eee2ad14d6 Content-transfer-encoding: 8BIT Message-id: <1424941884.27971.4.camel@AMDC1943> Subject: Re: [PATCH 1/2] staging:iio:hmc5843: Constify register tables and struct regmap_config From: Krzysztof Kozlowski To: Jonathan Cameron Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Thu, 26 Feb 2015 10:11:24 +0100 In-reply-to: <54EDB7E5.2050809@kernel.org> References: <1424770909-7360-1-git-send-email-k.kozlowski@samsung.com> <54EDB7E5.2050809@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xy7prH70LMbi/RN5iz5lf7BbNi9ez WTxoWsVksev/G2aLJZPns1rMO/KOxeLyrjlsFr93HWN34PC4t+8wi8eHj3Eem1Z1snnsn7uG 3WPJm0OsHuebjzB6fN4kF8AexWWTkpqTWZZapG+XwJXRfmE/e0GPYsXO/V9ZGhiXSHcxcnJI CJhInJh8hg3CFpO4cG89kM3FISSwlFHi+J0NzCAJXgFBiR+T77F0MXJwMAvISxy5lA0SZhZQ l5g0bxEzRP1nRolHs85C1etLLO2/ADZUWCBRov1hGwuIzSZgLLF5+RKwuAhQ87QZV5hAmpkF fjFKtK54zAaygEVAVeLeJh6QGk4BLYnJvTfZQWwhgTSJzg9v2UFKJASUJRr73SYwCsxCct0s hOtmIbluASPzKkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQ4P+yg3HxMatDjAIcjEo8vDNU 34YIsSaWFVfmHmKU4GBWEuG9dPNdiBBvSmJlVWpRfnxRaU5q8SFGJg5OqQZG8dQtrLy/+P4K uRwR5jad6VVxcP0jXqvJta2zj7vnLp75LFdg71HXWapz+nTbdmYLv7BM1EvJDGmVYviRM31j bmvwuuuu68vVPyu31P+ZduKFrOCl3d8sDKedtT4q72OzYUu8wG45s0PBH3p+tNct2qQbFTo9 2feFs4b9MsPUNVIulezLZvYqsRRnJBpqMRcVJwIA9W5871wCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On śro, 2015-02-25 at 11:54 +0000, Jonathan Cameron wrote: > On 24/02/15 09:41, Krzysztof Kozlowski wrote: > > The regmap_access_table and regmap_config structures may be const > > because they are not modified by the driver and regmap_init() accepts > > pointer to const. > > > > Signed-off-by: Krzysztof Kozlowski > Applied to the togreg branch of iio.git. Note I ended up hand applying > this due to DOS line endings and some fuzz. Thanks! I rebased the patchsed on next-20150224 so I did not expect any fuzz. Best regards, Krzysztof > > Jonathan > > --- > > drivers/staging/iio/magnetometer/hmc5843_i2c.c | 8 ++++---- > > drivers/staging/iio/magnetometer/hmc5843_spi.c | 8 ++++---- > > 2 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c > > index 6acd614cdbc6..8346cf81fc2e 100644 > > --- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c > > +++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c > > @@ -22,7 +22,7 @@ static const struct regmap_range hmc5843_readable_ranges[] = { > > regmap_reg_range(0, HMC5843_ID_END), > > }; > > > > -static struct regmap_access_table hmc5843_readable_table = { > > +static const struct regmap_access_table hmc5843_readable_table = { > > .yes_ranges = hmc5843_readable_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges), > > }; > > @@ -31,7 +31,7 @@ static const struct regmap_range hmc5843_writable_ranges[] = { > > regmap_reg_range(0, HMC5843_MODE_REG), > > }; > > > > -static struct regmap_access_table hmc5843_writable_table = { > > +static const struct regmap_access_table hmc5843_writable_table = { > > .yes_ranges = hmc5843_writable_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges), > > }; > > @@ -40,12 +40,12 @@ static const struct regmap_range hmc5843_volatile_ranges[] = { > > regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG), > > }; > > > > -static struct regmap_access_table hmc5843_volatile_table = { > > +static const struct regmap_access_table hmc5843_volatile_table = { > > .yes_ranges = hmc5843_volatile_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges), > > }; > > > > -static struct regmap_config hmc5843_i2c_regmap_config = { > > +static const struct regmap_config hmc5843_i2c_regmap_config = { > > .reg_bits = 8, > > .val_bits = 8, > > > > diff --git a/drivers/staging/iio/magnetometer/hmc5843_spi.c b/drivers/staging/iio/magnetometer/hmc5843_spi.c > > index 98c4b57101c9..8e658f736e1f 100644 > > --- a/drivers/staging/iio/magnetometer/hmc5843_spi.c > > +++ b/drivers/staging/iio/magnetometer/hmc5843_spi.c > > @@ -19,7 +19,7 @@ static const struct regmap_range hmc5843_readable_ranges[] = { > > regmap_reg_range(0, HMC5843_ID_END), > > }; > > > > -static struct regmap_access_table hmc5843_readable_table = { > > +static const struct regmap_access_table hmc5843_readable_table = { > > .yes_ranges = hmc5843_readable_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges), > > }; > > @@ -28,7 +28,7 @@ static const struct regmap_range hmc5843_writable_ranges[] = { > > regmap_reg_range(0, HMC5843_MODE_REG), > > }; > > > > -static struct regmap_access_table hmc5843_writable_table = { > > +static const struct regmap_access_table hmc5843_writable_table = { > > .yes_ranges = hmc5843_writable_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges), > > }; > > @@ -37,12 +37,12 @@ static const struct regmap_range hmc5843_volatile_ranges[] = { > > regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG), > > }; > > > > -static struct regmap_access_table hmc5843_volatile_table = { > > +static const struct regmap_access_table hmc5843_volatile_table = { > > .yes_ranges = hmc5843_volatile_ranges, > > .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges), > > }; > > > > -static struct regmap_config hmc5843_spi_regmap_config = { > > +static const struct regmap_config hmc5843_spi_regmap_config = { > > .reg_bits = 8, > > .val_bits = 8, > > > >