From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbbB0MgY (ORCPT ); Fri, 27 Feb 2015 07:36:24 -0500 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:41261 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752291AbbB0MgX (ORCPT ); Fri, 27 Feb 2015 07:36:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3872:3874:4321:5007:6261:7576:10004:10400:10848:11232:11658:11914:12517:12519:12740:13019:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bat74_547a111e24454 X-Filterd-Recvd-Size: 1475 Message-ID: <1425040579.2690.9.camel@perches.com> Subject: Re: [PATCH net-next] wireless: test sscanf return values From: Joe Perches To: David Laight Cc: Johannes Berg , "David S. Miller" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , LKML Date: Fri, 27 Feb 2015 04:36:19 -0800 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAF0B29@AcuExch.aculab.com> References: <1425015791.2690.7.camel@perches.com> <063D6719AE5E284EB5DD2968C1650D6D1CAF0B29@AcuExch.aculab.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-02-27 at 10:35 +0000, David Laight wrote: > From: Joe Perches > > At some point, it'd be good to make sscanf use __must_check > > so make sure the net/ uses of sscanf use the return value. > > Isn't it much safer to avoid sscanf() completely and use > a different function for converting numerics? It's generally better to use something other than sscanf. That doesn't mean sscanf isn't useful.