Re: [PATCH] Staging: fbtft: fix space errors

Dan Carpenter
2015-03-02T09:37:23Z

On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> If you're really going to change these, please
> remove the unnecessary \ line continuations
> indent the blocks properly and group the blocks
> more intelligibly. Maybe something like;
>
> static const int st7735r_init[] = {
> -1, 0x01,
> -2, 150,
> -1, 0x11,
> -2, 500,
> -1, 0xB1, 0x01, 0x2C, 0x2D,
> -1, 0xB2, 0x01, 0x2C, 0x2D,
> -1, 0xB3, 0x01, 0x2C, 0x2D, 0x01, 0x2C, 0x2D,
> -1, 0xB4, 0x07,
> -1, 0xC0, 0xA2, 0x02, 0x84,
> -1, 0xC1, 0xC5,
> -1, 0xC2, 0x0A, 0x00,
> -1, 0xC3, 0x8A, 0x2A,
> -1, 0xC4, 0x8A, 0xEE,
> -1, 0xC5, 0x0E,
> -1, 0x20,
> -1, 0x36, 0xC0,
> -1, 0x3A, 0x05,
> -1, 0xE0, 0x0f, 0x1a, 0x0f, 0x18, 0x2f, 0x28, 0x20, 0x22, 0x1f, 0x1b,
> 0x23, 0x37, 0x00, 0x07, 0x02, 0x10,
> -1, 0xE1, 0x0f, 0x1b, 0x0f, 0x17, 0x33, 0x2c, 0x29, 0x2e, 0x30, 0x30,
> 0x39, 0x3f, 0x00, 0x07, 0x03, 0x10,
> -1, 0x29,
> -2, 100,
> -1, 0x13,
> -2, 10,
> -3
> };

What's the logic here? Why are we putting the negatives first?

regards,
dan carpenter