Re: [PATCH] Staging: fbtft: fix space errors

Joe Perches
2015-03-02T14:20:56Z

On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
> On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> > If you're really going to change these, please
> > remove the unnecessary \ line continuations
> > indent the blocks properly and group the blocks
> > more intelligibly. Maybe something like;
> >
> > static const int st7735r_init[] = {
> > -1, 0x01,
[]
> > -2, 10,
> > -3
> > };
>
> What's the logic here? Why are we putting the negatives first?

Those are delimiters. see fbtft-core.c:fbtft_init_display().

As far as I understand:

-1, start of block
-2, millisecond delay after block write
-3, end of blocks

Beyond that, I don't much care.
I just prefer intelligible over apparently random.