From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbbB1TcV (ORCPT ); Sat, 28 Feb 2015 14:32:21 -0500 Received: from smtprelay0010.hostedemail.com ([216.40.44.10]:35941 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750808AbbB1TcU (ORCPT ); Sat, 28 Feb 2015 14:32:20 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2731:2828:3138:3139:3140:3141:3142:3354:3622:3865:3867:3868:3871:3873:4250:4321:5007:6119:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12050:12296:12438:12517:12519:12740:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: page44_889376f8fcc36 X-Filterd-Recvd-Size: 3280 Message-ID: <1425151935.25697.5.camel@perches.com> Subject: Re: [PATCH] rtc: add Abracon ABx80x driver From: Joe Perches To: Alexandre Belloni Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Date: Sat, 28 Feb 2015 11:32:15 -0800 In-Reply-To: <1425150876-8141-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1425150876-8141-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-02-28 at 20:14 +0100, Alexandre Belloni wrote: > Add support for the i2c RTC from Abracon. Perhaps you can run this through $ ./scripts/checkpatch.pl --strict --fix-inplace Is there going to be a MAINTAINERS entry for this driver? > diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile [] > @@ -22,6 +22,7 @@ rtc-core-$(CONFIG_RTC_INTF_SYSFS) += rtc-sysfs.o > > obj-$(CONFIG_RTC_DRV_88PM860X) += rtc-88pm860x.o > obj-$(CONFIG_RTC_DRV_88PM80X) += rtc-88pm80x.o > +obj-$(CONFIG_RTC_DRV_ABX80X) += rtc-abx80x.o alphabetic order? > obj-$(CONFIG_RTC_DRV_AB3100) += rtc-ab3100.o > obj-$(CONFIG_RTC_DRV_AB8500) += rtc-ab8500.o > obj-$(CONFIG_RTC_DRV_ABB5ZES3) += rtc-ab-b5ze-s3.o [] > diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c [] > +static int ab08xx_get_datetime(struct i2c_client *client, struct rtc_time *tm) > +{ > + unsigned char date[8]; > + int err; > + > + /* Now read time and date */ > + err = i2c_smbus_read_i2c_block_data(client, AB08XX_REG_HTH, > + 8, date); > + if (err < 0) { > + dev_err(&client->dev, "Unable to read date\n"); > + return -EIO; > + } > + > + tm->tm_sec = bcd2bin(date[AB08XX_REG_SC] & 0x7F); > + tm->tm_min = bcd2bin(date[AB08XX_REG_MN] & 0x7F); > + tm->tm_hour = bcd2bin(date[AB08XX_REG_HR] & 0x3F); > + tm->tm_wday = date[AB08XX_REG_WD] & 0x7; > + tm->tm_mday = bcd2bin(date[AB08XX_REG_DA] & 0x3F); > + tm->tm_mon = bcd2bin(date[AB08XX_REG_MO] & 0x1F) - 1; > + tm->tm_year = bcd2bin(date[AB08XX_REG_YR]); > + if (tm->tm_year < 70) > + tm->tm_year += 100; > + > + err = rtc_valid_tm(tm); > + if (err < 0) > + dev_err(&client->dev, "retrieved date/time is not valid.\n"); Is setting the date to a known bad value really the desired thing? > +static int ab08xx_probe(struct i2c_client *client, > + const struct i2c_device_id *id) > +{ > + struct rtc_device *rtc; > + int data, err, part0, part1; > + > + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > + return -ENODEV; > + > + > + part0 = i2c_smbus_read_byte_data(client, AB08XX_REG_PART0); > + part1 = i2c_smbus_read_byte_data(client, AB08XX_REG_PART1); > + if ((part0 < 0) || (part1 < 0)) { > + dev_err(&client->dev, "Unable to read part number\n"); > + return -EIO; > + } > + dev_info(&client->dev, "chip found %2x%2x\n", part0, part1); "%02x%02x" ?