From: Arjun Sreedharan <arjun024@gmail.com>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Michal Marek <mmarek@suse.cz>, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] docproc: handle realloc() failure in find_all_symbols()
Date: Sun, 1 Mar 2015 01:37:22 +0530 [thread overview]
Message-ID: <1425154042-3474-1-git-send-email-arjun024@gmail.com> (raw)
check realloc rc and avoid potential null dereference
and memory leak
Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
---
scripts/docproc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index e267e621..438fc91 100644
--- a/scripts/docproc.c
+++ b/scripts/docproc.c
@@ -396,6 +396,10 @@ static void find_all_symbols(char *filename)
4096)) > 0) {
data_len += ret;
data = realloc(data, data_len + 4096);
+ if (data == NULL) {
+ perror("realloc");
+ exit(1);
+ }
}
} while (ret == -EAGAIN);
if (ret != 0) {
@@ -420,6 +424,10 @@ static void find_all_symbols(char *filename)
start = all_list_len;
all_list_len += count;
all_list = realloc(all_list, sizeof(char *) * all_list_len);
+ if (all_list == NULL) {
+ perror("realloc");
+ exit(1);
+ }
str = data;
for (i = 0; i < data_len && start != all_list_len; i++) {
if (data[i] == '\0') {
--
1.8.1.msysgit.1
reply other threads:[~2015-02-28 20:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425154042-3474-1-git-send-email-arjun024@gmail.com \
--to=arjun024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox