From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbbCAXpz (ORCPT ); Sun, 1 Mar 2015 18:45:55 -0500 Received: from smtprelay0041.hostedemail.com ([216.40.44.41]:46462 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751313AbbCAXpx (ORCPT ); Sun, 1 Mar 2015 18:45:53 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:973:979:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3874:4321:4383:5007:6248:6261:7522:7903:8527:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13149:13230:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: iron52_5030ea6002b02 X-Filterd-Recvd-Size: 2002 Message-ID: <1425253549.31561.9.camel@perches.com> Subject: Re: [PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset From: Joe Perches To: Aya Mahfouz Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Date: Sun, 01 Mar 2015 15:45:49 -0800 In-Reply-To: <20150301233806.GA19189@waves> References: <20150301214350.GA13024@waves> <1425248001.31561.7.camel@perches.com> <20150301233806.GA19189@waves> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-02 at 01:38 +0200, Aya Mahfouz wrote: > On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote: > > On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote: > > > calls > > > Reply-To: > > > > > > Add 2 new checks on memset calls in the file checkpatch.pl as follows: > > > > Hi again Aya > > > > The initial 3 lines here aren't necessary. > > > > I think it'd be a better subject line with something like > > "checkpatch: prefer eth__addr over memset(,,ETH_ALEN)" > > > ok, should I resend it as a fresh patch or send the patch with a new > subject line and state that it is v4? Send V4 with new subject and cc Andrew. > > Please cc Andrew Morton > > And please also don't add Signed-off-by: lines for > > anyone other than yourself. > > > ok, I will cc Andrew. As for your tag, I couldn't take credit > for the regex that I did not write. Will not do it in the future again > unless the other side agrees to it. No worries from me. "Suggested-by:" or "Portions-by:" or just some text with "credit to: " for the suggestions, etc cheers, Joe